9pfsd: allow building with old glibc

[PATCH] 9pfsd: allow building with old glibc

Posted by Jan Beulich 1 month, 4 weeks ago

Neither pread() / pwrite() nor O_DIRECTORY are available from glibc
2.11.3 headers without defining (e.g.) _GNU_SOURCE. Supplying the
definition unconditionally shouldn't be a problem, seeing that various
other tools/ components do so, too.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/9pfsd/Makefile
+++ b/tools/9pfsd/Makefile
@@ -5,7 +5,7 @@
 XEN_ROOT = $(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += $(PTHREAD_CFLAGS)
+CFLAGS += $(PTHREAD_CFLAGS) -D_GNU_SOURCE
 LDFLAGS += $(PTHREAD_LDFLAGS)
 
 TARGETS := xen-9pfsd

Re: [PATCH] 9pfsd: allow building with old glibc

Posted by Jürgen Groß 1 month, 4 weeks ago

On 05.03.24 15:33, Jan Beulich wrote:
> Neither pread() / pwrite() nor O_DIRECTORY are available from glibc
> 2.11.3 headers without defining (e.g.) _GNU_SOURCE. Supplying the
> definition unconditionally shouldn't be a problem, seeing that various
> other tools/ components do so, too.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Fine with me.

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

Re: [PATCH] 9pfsd: allow building with old glibc

Posted by Anthony PERARD 1 month, 3 weeks ago

On Tue, Mar 05, 2024 at 04:23:23PM +0100, Jürgen Groß wrote:
> On 05.03.24 15:33, Jan Beulich wrote:
> > Neither pread() / pwrite() nor O_DIRECTORY are available from glibc
> > 2.11.3 headers without defining (e.g.) _GNU_SOURCE. Supplying the
> > definition unconditionally shouldn't be a problem, seeing that various
> > other tools/ components do so, too.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Fine with me.
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD