From: Mykola Kvach <mykola_kvach@epam.com>

Corrected a typo in a comment within vpsci.c:
  replaced "SCCC_SMCCC_*_REVISION" with the correct "SSSC_SMCCC_*_REVISION".

This change improves clarity but does not affect functionality.

Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>
---
 xen/arch/arm/vpsci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/vpsci.c b/xen/arch/arm/vpsci.c
index d1615be8a6..7ba9ccd94b 100644
--- a/xen/arch/arm/vpsci.c
+++ b/xen/arch/arm/vpsci.c
@@ -268,7 +268,7 @@ bool do_vpsci_0_2_call(struct cpu_user_regs *regs, uint32_t fid)
 {
     /*
      * /!\ VPSCI_NR_FUNCS (in asm/vpsci.h) should be updated when
-     * adding/removing a function. SCCC_SMCCC_*_REVISION should be
+     * adding/removing a function. SSSC_SMCCC_*_REVISION should be
      * updated once per release.
      */
     switch ( fid )
-- 
2.48.1

On 29/05/2025 21:40, Mykola Kvach wrote:
> From: Mykola Kvach <mykola_kvach@epam.com>
> 
> Corrected a typo in a comment within vpsci.c:
NIT: use imperative mood in commit msg

>   replaced "SCCC_SMCCC_*_REVISION" with the correct "SSSC_SMCCC_*_REVISION".
> 
> This change improves clarity but does not affect functionality.
> 
> Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>
Reviewed-by: Michal Orzel <michal.orzel@amd.com>

~Michal

> ---
>  xen/arch/arm/vpsci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/vpsci.c b/xen/arch/arm/vpsci.c
> index d1615be8a6..7ba9ccd94b 100644
> --- a/xen/arch/arm/vpsci.c
> +++ b/xen/arch/arm/vpsci.c
> @@ -268,7 +268,7 @@ bool do_vpsci_0_2_call(struct cpu_user_regs *regs, uint32_t fid)
>  {
>      /*
>       * /!\ VPSCI_NR_FUNCS (in asm/vpsci.h) should be updated when
> -     * adding/removing a function. SCCC_SMCCC_*_REVISION should be
> +     * adding/removing a function. SSSC_SMCCC_*_REVISION should be
>       * updated once per release.
>       */
>      switch ( fid )

Hi, @Michal Orzel

On Fri, May 30, 2025 at 9:43 AM Orzel, Michal <michal.orzel@amd.com> wrote:
>
>
>
> On 29/05/2025 21:40, Mykola Kvach wrote:
> > From: Mykola Kvach <mykola_kvach@epam.com>
> >
> > Corrected a typo in a comment within vpsci.c:
> NIT: use imperative mood in commit msg
Thank you for pointing that out. I’ll correct it.

>
> >   replaced "SCCC_SMCCC_*_REVISION" with the correct "SSSC_SMCCC_*_REVISION".
> >
> > This change improves clarity but does not affect functionality.
> >
> > Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>
> Reviewed-by: Michal Orzel <michal.orzel@amd.com>
>
> ~Michal
>
> > ---
> >  xen/arch/arm/vpsci.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/arm/vpsci.c b/xen/arch/arm/vpsci.c
> > index d1615be8a6..7ba9ccd94b 100644
> > --- a/xen/arch/arm/vpsci.c
> > +++ b/xen/arch/arm/vpsci.c
> > @@ -268,7 +268,7 @@ bool do_vpsci_0_2_call(struct cpu_user_regs *regs, uint32_t fid)
> >  {
> >      /*
> >       * /!\ VPSCI_NR_FUNCS (in asm/vpsci.h) should be updated when
> > -     * adding/removing a function. SCCC_SMCCC_*_REVISION should be
> > +     * adding/removing a function. SSSC_SMCCC_*_REVISION should be
> >       * updated once per release.
> >       */
> >      switch ( fid )
>

Best regards,
Mykola

On 30/05/2025 09:43, Mykola Kvach wrote:
> Hi, @Michal Orzel
> 
> On Fri, May 30, 2025 at 9:43 AM Orzel, Michal <michal.orzel@amd.com> wrote:
>>
>>
>>
>> On 29/05/2025 21:40, Mykola Kvach wrote:
>>> From: Mykola Kvach <mykola_kvach@epam.com>
>>>
>>> Corrected a typo in a comment within vpsci.c:
>> NIT: use imperative mood in commit msg
> Thank you for pointing that out. I’ll correct it.
No need. The patch is already committed. This was a NIT for the future.

~Michal