[PATCH 4.14] vPCI: replace %pp

Jan Beulich posted 1 patch 2 years ago
Failed in applying to current master (apply log)
[PATCH 4.14] vPCI: replace %pp
Posted by Jan Beulich 2 years ago
4.14 doesn't know of this format specifier extension yet.

Fixes: 47188b2fdcc6 ("vpci/msix: fix PBA accesses")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -258,8 +258,9 @@ static int msix_read(struct vcpu *v, uns
         if ( !pba )
         {
             gprintk(XENLOG_WARNING,
-                    "%pp: unable to map MSI-X PBA, report all pending\n",
-                    msix->pdev);
+                    "%04x:%02x:%02x.%u: unable to map MSI-X PBA, report all pending\n",
+                    msix->pdev->seg, msix->pdev->bus, PCI_SLOT(msix->pdev->devfn),
+                    PCI_FUNC(msix->pdev->devfn));
             return X86EMUL_OKAY;
         }
 
@@ -342,8 +343,10 @@ static int msix_write(struct vcpu *v, un
             {
                 /* Unable to map the PBA, ignore write. */
                 gprintk(XENLOG_WARNING,
-                        "%pp: unable to map MSI-X PBA, write ignored\n",
-                        msix->pdev);
+                        "%04x:%02x:%02x.%u: unable to map MSI-X PBA, write ignored\n",
+                        msix->pdev->seg, msix->pdev->bus,
+                        PCI_SLOT(msix->pdev->devfn),
+                        PCI_FUNC(msix->pdev->devfn));
                 return X86EMUL_OKAY;
             }
Re: [PATCH 4.14] vPCI: replace %pp
Posted by Roger Pau Monné 2 years ago
On Thu, Apr 07, 2022 at 05:04:04PM +0200, Jan Beulich wrote:
> 4.14 doesn't know of this format specifier extension yet.
> 
> Fixes: 47188b2fdcc6 ("vpci/msix: fix PBA accesses")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.