1. Patchew
  2. Xen
  3. View series

[PATCH v2] automation/eclair: monitor rules 11.6, 17.2, 18.3, 21.11, 21.14-16

Dmytro Prokopchuk1 posted 1 patch 3 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/35b3116fd3d4681ef3cf80a87b12c66055ce4342.1753283164.git.dmytro._5Fprokopchuk1@epam.com
There is a newer version of this series
automation/eclair_analysis/ECLAIR/monitored.ecl | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
[PATCH v2] automation/eclair: monitor rules 11.6, 17.2, 18.3, 21.11, 21.14-16
Posted by Dmytro Prokopchuk1 3 months, 1 week ago 
Add MISRA C rules to the monitored set.
All these rules are 'accepted' for XEN, have zero or few violations,
and should be enabled for the ECLAIR scan.

Rule 17.2 is enabled to prevent accidental direct recursion.

Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@epam.com>
---
Changes in v2:
- updated commit message
---
 automation/eclair_analysis/ECLAIR/monitored.ecl | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/automation/eclair_analysis/ECLAIR/monitored.ecl b/automation/eclair_analysis/ECLAIR/monitored.ecl
index 00bff9edbe..72698b2eb1 100644
--- a/automation/eclair_analysis/ECLAIR/monitored.ecl
+++ b/automation/eclair_analysis/ECLAIR/monitored.ecl
@@ -45,6 +45,7 @@
 -enable=MC3A2.R10.2
 -enable=MC3A2.R11.1
 -enable=MC3A2.R11.2
+-enable=MC3A2.R11.6
 -enable=MC3A2.R11.7
 -enable=MC3A2.R11.8
 -enable=MC3A2.R11.9
@@ -62,12 +63,14 @@
 -enable=MC3A2.R16.6
 -enable=MC3A2.R16.7
 -enable=MC3A2.R17.1
+-enable=MC3A2.R17.2
 -enable=MC3A2.R17.3
 -enable=MC3A2.R17.4
 -enable=MC3A2.R17.5
 -enable=MC3A2.R17.6
 -enable=MC3A2.R18.1
 -enable=MC3A2.R18.2
+-enable=MC3A2.R18.3
 -enable=MC3A2.R18.6
 -enable=MC3A2.R18.8
 -enable=MC3A2.R19.1
@@ -83,14 +86,18 @@
 -enable=MC3A2.R20.14
 -enable=MC3A2.R21.3
 -enable=MC3A2.R21.4
--enable=MC3A2.R21.6
 -enable=MC3A2.R21.5
+-enable=MC3A2.R21.6
 -enable=MC3A2.R21.7
 -enable=MC3A2.R21.8
 -enable=MC3A2.R21.9
 -enable=MC3A2.R21.10
+-enable=MC3A2.R21.11
 -enable=MC3A2.R21.12
 -enable=MC3A2.R21.13
+-enable=MC3A2.R21.14
+-enable=MC3A2.R21.15
+-enable=MC3A2.R21.16
 -enable=MC3A2.R21.17
 -enable=MC3A2.R21.18
 -enable=MC3A2.R21.19
-- 
2.43.0
Re: [PATCH v2] automation/eclair: monitor rules 11.6, 17.2, 18.3, 21.11, 21.14-16
Posted by Stefano Stabellini 3 months, 1 week ago 
On Wed, 23 Jul 2025, Dmytro Prokopchuk1 wrote:
> Add MISRA C rules to the monitored set.
> All these rules are 'accepted' for XEN, have zero or few violations,
> and should be enabled for the ECLAIR scan.
> 
> Rule 17.2 is enabled to prevent accidental direct recursion.
> 
> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@epam.com>

Please provide a link to a passed pipeline. With that:

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes in v2:
> - updated commit message
> ---
>  automation/eclair_analysis/ECLAIR/monitored.ecl | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/automation/eclair_analysis/ECLAIR/monitored.ecl b/automation/eclair_analysis/ECLAIR/monitored.ecl
> index 00bff9edbe..72698b2eb1 100644
> --- a/automation/eclair_analysis/ECLAIR/monitored.ecl
> +++ b/automation/eclair_analysis/ECLAIR/monitored.ecl
> @@ -45,6 +45,7 @@
>  -enable=MC3A2.R10.2
>  -enable=MC3A2.R11.1
>  -enable=MC3A2.R11.2
> +-enable=MC3A2.R11.6
>  -enable=MC3A2.R11.7
>  -enable=MC3A2.R11.8
>  -enable=MC3A2.R11.9
> @@ -62,12 +63,14 @@
>  -enable=MC3A2.R16.6
>  -enable=MC3A2.R16.7
>  -enable=MC3A2.R17.1
> +-enable=MC3A2.R17.2
>  -enable=MC3A2.R17.3
>  -enable=MC3A2.R17.4
>  -enable=MC3A2.R17.5
>  -enable=MC3A2.R17.6
>  -enable=MC3A2.R18.1
>  -enable=MC3A2.R18.2
> +-enable=MC3A2.R18.3
>  -enable=MC3A2.R18.6
>  -enable=MC3A2.R18.8
>  -enable=MC3A2.R19.1
> @@ -83,14 +86,18 @@
>  -enable=MC3A2.R20.14
>  -enable=MC3A2.R21.3
>  -enable=MC3A2.R21.4
> --enable=MC3A2.R21.6
>  -enable=MC3A2.R21.5
> +-enable=MC3A2.R21.6
>  -enable=MC3A2.R21.7
>  -enable=MC3A2.R21.8
>  -enable=MC3A2.R21.9
>  -enable=MC3A2.R21.10
> +-enable=MC3A2.R21.11
>  -enable=MC3A2.R21.12
>  -enable=MC3A2.R21.13
> +-enable=MC3A2.R21.14
> +-enable=MC3A2.R21.15
> +-enable=MC3A2.R21.16
>  -enable=MC3A2.R21.17
>  -enable=MC3A2.R21.18
>  -enable=MC3A2.R21.19
> -- 
> 2.43.0
>
Re: [PATCH v2] automation/eclair: monitor rules 11.6, 17.2, 18.3, 21.11, 21.14-16
Posted by Jan Beulich 3 months, 1 week ago 
On 23.07.2025 17:07, Dmytro Prokopchuk1 wrote:
> Add MISRA C rules to the monitored set.
> All these rules are 'accepted' for XEN, have zero or few violations,
> and should be enabled for the ECLAIR scan.
> 
> Rule 17.2 is enabled to prevent accidental direct recursion.

How does this "prevent" work? I see no deviations so far, despite there being
a few cases of recursion. Hence if one had a need to introduce another variant,
how would one go about doing so with no code usable as reference?

Jan
Re: [PATCH v2] automation/eclair: monitor rules 11.6, 17.2, 18.3, 21.11, 21.14-16
Posted by Dmytro Prokopchuk1 3 months, 1 week ago 

On 7/23/25 18:14, Jan Beulich wrote:
> On 23.07.2025 17:07, Dmytro Prokopchuk1 wrote:
>> Add MISRA C rules to the monitored set.
>> All these rules are 'accepted' for XEN, have zero or few violations,
>> and should be enabled for the ECLAIR scan.
>>
>> Rule 17.2 is enabled to prevent accidental direct recursion.
> 
> How does this "prevent" work? I see no deviations so far, despite there being
> a few cases of recursion. Hence if one had a need to introduce another variant,
> how would one go about doing so with no code usable as reference?
> 
> Jan
I agree. Word "prevent" is inappropriate here.
Better to say "monitor" or "scan".

Dmytro.

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.