With all paths into hvmemul_linear_mmio_access() coming through
linear_{read,write}(), there's no need anymore to split accesses at
page boundaries there. Leave an assertion, though.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Replace ASSERT() by more safe construct.
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -1084,7 +1084,7 @@ static int hvmemul_linear_mmio_access(
{
struct hvm_vcpu_io *hvio = ¤t->arch.hvm.hvm_io;
unsigned long offset = gla & ~PAGE_MASK;
- unsigned int chunk, buffer_offset = gla - start;
+ unsigned int buffer_offset = gla - start;
struct hvm_mmio_cache *cache = hvmemul_find_mmio_cache(hvio, start, dir,
buffer_offset);
paddr_t gpa;
@@ -1094,13 +1094,17 @@ static int hvmemul_linear_mmio_access(
if ( cache == NULL )
return X86EMUL_UNHANDLEABLE;
- chunk = min_t(unsigned int, size, PAGE_SIZE - offset);
+ if ( size > PAGE_SIZE - offset )
+ {
+ ASSERT_UNREACHABLE();
+ return X86EMUL_UNHANDLEABLE;
+ }
if ( known_gpfn )
gpa = pfn_to_paddr(hvio->mmio_gpfn) | offset;
else
{
- rc = hvmemul_linear_to_phys(gla, &gpa, chunk, &one_rep, pfec,
+ rc = hvmemul_linear_to_phys(gla, &gpa, size, &one_rep, pfec,
hvmemul_ctxt);
if ( rc != X86EMUL_OKAY )
return rc;
@@ -1108,27 +1112,8 @@ static int hvmemul_linear_mmio_access(
latch_linear_to_phys(hvio, gla, gpa, dir == IOREQ_WRITE);
}
- for ( ;; )
- {
- rc = hvmemul_phys_mmio_access(cache, gpa, chunk, dir, buffer, buffer_offset);
- if ( rc != X86EMUL_OKAY )
- break;
-
- gla += chunk;
- buffer_offset += chunk;
- size -= chunk;
-
- if ( size == 0 )
- break;
-
- chunk = min_t(unsigned int, size, PAGE_SIZE);
- rc = hvmemul_linear_to_phys(gla, &gpa, chunk, &one_rep, pfec,
- hvmemul_ctxt);
- if ( rc != X86EMUL_OKAY )
- return rc;
- }
-
- return rc;
+ return hvmemul_phys_mmio_access(cache, gpa, size, dir, buffer,
+ buffer_offset);
}
static inline int hvmemul_linear_mmio_read(