[v1] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB

[PATCH] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB

Petr Beneš posted 1 patch 11 months, 2 weeks ago

Diff against v2
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/2bb71b2ba88e6eb6177c27dd65f2af608a634ac2.1707261567.git.w1benny@gmail.com

There is a newer version of this series

tools/include/libxl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB

Posted by Petr Beneš 11 months, 2 weeks ago

From: Petr Beneš <w1benny@gmail.com>

It's located in libxl_domain_build_info, not libxl_domain_create_info.
---
 tools/include/libxl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 907aa0a330..14f69823e0 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -519,7 +519,7 @@
 #define LIBXL_HAVE_PHYSINFO_CAP_VMTRACE 1
 
 /*
- * LIBXL_HAVE_VMTRACE_BUF_KB indicates that libxl_domain_create_info has a
+ * LIBXL_HAVE_VMTRACE_BUF_KB indicates that libxl_domain_build_info has a
  * vmtrace_buf_kb parameter, which allows to enable pre-allocation of
  * processor tracing buffers of given size.
  */
-- 
2.34.1

Re: [PATCH] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB

Posted by Anthony PERARD 11 months, 1 week ago

On Tue, Feb 06, 2024 at 11:23:45PM +0000, Petr Beneš wrote:
> From: Petr Beneš <w1benny@gmail.com>
> 
> It's located in libxl_domain_build_info, not libxl_domain_create_info.

Hi Petr,

You need a "Signed-off-by:" tag when sending patches.

We could probably add also a fixes tag
Fixes: 45ba9a7d7688 ("tools/[lib]xl: Add vmtrace_buf_size parameter")

Otherwise, patch looks fine, so with the SOB: Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD