xen/numa: address a violation of MISRA C:2012 Rule 8.3

[XEN PATCH] xen/numa: address a violation of MISRA C:2012 Rule 8.3

Posted by Federico Serafini 7 months, 1 week ago

Make object declarations consistent. No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/include/xen/numa.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 29b8c2df89..287e81ff66 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -60,7 +60,7 @@ static inline void clear_node_cpumask(unsigned int cpu)
 /* Simple perfect hash to map pdx to node numbers */
 extern unsigned int memnode_shift;
 extern unsigned long memnodemapsize;
-extern uint8_t *memnodemap;
+extern nodeid_t *memnodemap;
 
 struct node_data {
     unsigned long node_start_pfn;
-- 
2.34.1

Re: [XEN PATCH] xen/numa: address a violation of MISRA C:2012 Rule 8.3

Posted by Stefano Stabellini 7 months, 1 week ago

On Thu, 21 Sep 2023, Federico Serafini wrote:
> Make object declarations consistent. No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  xen/include/xen/numa.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
> index 29b8c2df89..287e81ff66 100644
> --- a/xen/include/xen/numa.h
> +++ b/xen/include/xen/numa.h
> @@ -60,7 +60,7 @@ static inline void clear_node_cpumask(unsigned int cpu)
>  /* Simple perfect hash to map pdx to node numbers */
>  extern unsigned int memnode_shift;
>  extern unsigned long memnodemapsize;
> -extern uint8_t *memnodemap;
> +extern nodeid_t *memnodemap;
>  
>  struct node_data {
>      unsigned long node_start_pfn;
> -- 
> 2.34.1
>

Re: [XEN PATCH] xen/numa: address a violation of MISRA C:2012 Rule 8.3

Posted by Henry Wang 7 months, 1 week ago

Hi,

> On Sep 22, 2023, at 06:30, Stefano Stabellini <sstabellini@kernel.org> wrote:
> 
> On Thu, 21 Sep 2023, Federico Serafini wrote:
>> Make object declarations consistent. No functional change.
>> 
>> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry