x86/mm: undo type change of partial_flags

[PATCH] x86/mm: undo type change of partial_flags

Posted by Jan Beulich 1 year, 1 month ago

Clang dislikes the boolean type combined with the field being set using
PTF_partial_set.

Fixes: 5ffe6d4a02e0 ("types: replace remaining uses of s16")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/include/asm/mm.h
+++ b/xen/arch/x86/include/asm/mm.h
@@ -286,7 +286,7 @@ struct page_info
         struct {
             u16 nr_validated_ptes:PAGETABLE_ORDER + 1;
             u16 :16 - PAGETABLE_ORDER - 1 - 1;
-            bool partial_flags:1;
+            uint16_t partial_flags:1;
             int16_t linear_pt_count;
         };

Re: [PATCH] x86/mm: undo type change of partial_flags

Posted by Roger Pau Monné 1 year, 1 month ago

On Thu, Sep 12, 2024 at 05:38:17PM +0200, Jan Beulich wrote:
> Clang dislikes the boolean type combined with the field being set using
> PTF_partial_set.
> 
> Fixes: 5ffe6d4a02e0 ("types: replace remaining uses of s16")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.

Re: [PATCH] x86/mm: undo type change of partial_flags

Posted by Andrew Cooper 1 year, 1 month ago

On 12/09/2024 4:38 pm, Jan Beulich wrote:
> Clang dislikes the boolean type combined with the field being set using
> PTF_partial_set.
>
> Fixes: 5ffe6d4a02e0 ("types: replace remaining uses of s16")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Re: [PATCH] x86/mm: undo type change of partial_flags

Posted by Frediano Ziglio 1 year, 1 month ago

On Thu, Sep 12, 2024 at 4:38 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> Clang dislikes the boolean type combined with the field being set using
> PTF_partial_set.
>
> Fixes: 5ffe6d4a02e0 ("types: replace remaining uses of s16")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/include/asm/mm.h
> +++ b/xen/arch/x86/include/asm/mm.h
> @@ -286,7 +286,7 @@ struct page_info
>          struct {
>              u16 nr_validated_ptes:PAGETABLE_ORDER + 1;
>              u16 :16 - PAGETABLE_ORDER - 1 - 1;
> -            bool partial_flags:1;
> +            uint16_t partial_flags:1;
>              int16_t linear_pt_count;
>          };
>
>
I knew MS compiler does not like too, but I only tested with GCC, and
it was fine with it

Reviewed-by: Frediano Ziglio <frediano.ziglio@cloud.com>

Frediano