1. Patchew
  2. Xen
  3. View series

[PATCH] automation/eclair: monitor rules 11.6, 17.2, 18.3, 21.11, 21.14-16

Dmytro Prokopchuk1 posted 1 patch 3 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/2134a233586a6aeb5de740baf082ba87ecb212df.1753271488.git.dmytro._5Fprokopchuk1@epam.com
There is a newer version of this series
automation/eclair_analysis/ECLAIR/monitored.ecl | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
[PATCH] automation/eclair: monitor rules 11.6, 17.2, 18.3, 21.11, 21.14-16
Posted by Dmytro Prokopchuk1 3 months, 1 week ago 
Add MISRA C rules to the monitored set.
All these rules are 'accepted' for XEN, have zero or few violations,
and should be enabled for the ECLAIR scan.

Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@epam.com>
---
Test CI: https://gitlab.com/xen-project/people/dimaprkp4k/xen/-/pipelines/1943607023
---
 automation/eclair_analysis/ECLAIR/monitored.ecl | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/automation/eclair_analysis/ECLAIR/monitored.ecl b/automation/eclair_analysis/ECLAIR/monitored.ecl
index 00bff9edbe..72698b2eb1 100644
--- a/automation/eclair_analysis/ECLAIR/monitored.ecl
+++ b/automation/eclair_analysis/ECLAIR/monitored.ecl
@@ -45,6 +45,7 @@
 -enable=MC3A2.R10.2
 -enable=MC3A2.R11.1
 -enable=MC3A2.R11.2
+-enable=MC3A2.R11.6
 -enable=MC3A2.R11.7
 -enable=MC3A2.R11.8
 -enable=MC3A2.R11.9
@@ -62,12 +63,14 @@
 -enable=MC3A2.R16.6
 -enable=MC3A2.R16.7
 -enable=MC3A2.R17.1
+-enable=MC3A2.R17.2
 -enable=MC3A2.R17.3
 -enable=MC3A2.R17.4
 -enable=MC3A2.R17.5
 -enable=MC3A2.R17.6
 -enable=MC3A2.R18.1
 -enable=MC3A2.R18.2
+-enable=MC3A2.R18.3
 -enable=MC3A2.R18.6
 -enable=MC3A2.R18.8
 -enable=MC3A2.R19.1
@@ -83,14 +86,18 @@
 -enable=MC3A2.R20.14
 -enable=MC3A2.R21.3
 -enable=MC3A2.R21.4
--enable=MC3A2.R21.6
 -enable=MC3A2.R21.5
+-enable=MC3A2.R21.6
 -enable=MC3A2.R21.7
 -enable=MC3A2.R21.8
 -enable=MC3A2.R21.9
 -enable=MC3A2.R21.10
+-enable=MC3A2.R21.11
 -enable=MC3A2.R21.12
 -enable=MC3A2.R21.13
+-enable=MC3A2.R21.14
+-enable=MC3A2.R21.15
+-enable=MC3A2.R21.16
 -enable=MC3A2.R21.17
 -enable=MC3A2.R21.18
 -enable=MC3A2.R21.19
-- 
2.43.0
Re: [PATCH] automation/eclair: monitor rules 11.6, 17.2, 18.3, 21.11, 21.14-16
Posted by Nicola Vetrini 3 months, 1 week ago 
On 2025-07-23 15:30, Dmytro Prokopchuk1 wrote:
> Add MISRA C rules to the monitored set.
> All these rules are 'accepted' for XEN, have zero or few violations,
> and should be enabled for the ECLAIR scan.
> 
> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@epam.com>
> ---
> Test CI: 
> https://gitlab.com/xen-project/people/dimaprkp4k/xen/-/pipelines/1943607023
> ---
>  automation/eclair_analysis/ECLAIR/monitored.ecl | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 

If some have zero violations they should be tagged as "clean" in 
tagging.ecl

> diff --git a/automation/eclair_analysis/ECLAIR/monitored.ecl 
> b/automation/eclair_analysis/ECLAIR/monitored.ecl
> index 00bff9edbe..72698b2eb1 100644
> --- a/automation/eclair_analysis/ECLAIR/monitored.ecl
> +++ b/automation/eclair_analysis/ECLAIR/monitored.ecl
> @@ -45,6 +45,7 @@
>  -enable=MC3A2.R10.2
>  -enable=MC3A2.R11.1
>  -enable=MC3A2.R11.2
> +-enable=MC3A2.R11.6
>  -enable=MC3A2.R11.7
>  -enable=MC3A2.R11.8
>  -enable=MC3A2.R11.9
> @@ -62,12 +63,14 @@
>  -enable=MC3A2.R16.6
>  -enable=MC3A2.R16.7
>  -enable=MC3A2.R17.1
> +-enable=MC3A2.R17.2

This might make sense only to avoid directly recursive functions being 
accidentally introduced. We are working at improving the granularity of 
the reports for indirect recursion, but the rationale of the addition 
should to be mentioned in the description

>  -enable=MC3A2.R17.3
>  -enable=MC3A2.R17.4
>  -enable=MC3A2.R17.5
>  -enable=MC3A2.R17.6
>  -enable=MC3A2.R18.1
>  -enable=MC3A2.R18.2
> +-enable=MC3A2.R18.3
>  -enable=MC3A2.R18.6
>  -enable=MC3A2.R18.8
>  -enable=MC3A2.R19.1
> @@ -83,14 +86,18 @@
>  -enable=MC3A2.R20.14
>  -enable=MC3A2.R21.3
>  -enable=MC3A2.R21.4
> --enable=MC3A2.R21.6
>  -enable=MC3A2.R21.5
> +-enable=MC3A2.R21.6
>  -enable=MC3A2.R21.7
>  -enable=MC3A2.R21.8
>  -enable=MC3A2.R21.9
>  -enable=MC3A2.R21.10
> +-enable=MC3A2.R21.11
>  -enable=MC3A2.R21.12
>  -enable=MC3A2.R21.13
> +-enable=MC3A2.R21.14
> +-enable=MC3A2.R21.15
> +-enable=MC3A2.R21.16
>  -enable=MC3A2.R21.17
>  -enable=MC3A2.R21.18
>  -enable=MC3A2.R21.19

-- 
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
Re: [PATCH] automation/eclair: monitor rules 11.6, 17.2, 18.3, 21.11, 21.14-16
Posted by Dmytro Prokopchuk1 3 months, 1 week ago 

On 7/23/25 16:34, Nicola Vetrini wrote:
> On 2025-07-23 15:30, Dmytro Prokopchuk1 wrote:
>> Add MISRA C rules to the monitored set.
>> All these rules are 'accepted' for XEN, have zero or few violations,
>> and should be enabled for the ECLAIR scan.
>>
>> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@epam.com>
>> ---
>> Test CI: https://eur01.safelinks.protection.outlook.com/? 
>> url=https%3A%2F%2Fgitlab.com%2Fxen- 
>> project%2Fpeople%2Fdimaprkp4k%2Fxen%2F- 
>> %2Fpipelines%2F1943607023&data=05%7C02%7Cdmytro_prokopchuk1%40epam.com%7C842de076f5654d6ed95108ddc9edb2d4%7Cb41b72d04e9f4c268a69f949f367c91d%7C1%7C0%7C638888744936562609%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Xu4i8vFHdUyiX0sfXtdIuwOROrHO4RMj5862fJcA%2BRE%3D&reserved=0
>> ---
>>  automation/eclair_analysis/ECLAIR/monitored.ecl | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>
> 
> If some have zero violations they should be tagged as "clean" in 
> tagging.ecl
Yep, the next patch is in progress.
> 
>> diff --git a/automation/eclair_analysis/ECLAIR/monitored.ecl b/ 
>> automation/eclair_analysis/ECLAIR/monitored.ecl
>> index 00bff9edbe..72698b2eb1 100644
>> --- a/automation/eclair_analysis/ECLAIR/monitored.ecl
>> +++ b/automation/eclair_analysis/ECLAIR/monitored.ecl
>> @@ -45,6 +45,7 @@
>>  -enable=MC3A2.R10.2
>>  -enable=MC3A2.R11.1
>>  -enable=MC3A2.R11.2
>> +-enable=MC3A2.R11.6
>>  -enable=MC3A2.R11.7
>>  -enable=MC3A2.R11.8
>>  -enable=MC3A2.R11.9
>> @@ -62,12 +63,14 @@
>>  -enable=MC3A2.R16.6
>>  -enable=MC3A2.R16.7
>>  -enable=MC3A2.R17.1
>> +-enable=MC3A2.R17.2
> 
> This might make sense only to avoid directly recursive functions being 
> accidentally introduced. We are working at improving the granularity of 
> the reports for indirect recursion, but the rationale of the addition 
> should to be mentioned in the description
Thanks, Nicola. I'll add comment.
> 
>>  -enable=MC3A2.R17.3
>>  -enable=MC3A2.R17.4
>>  -enable=MC3A2.R17.5
>>  -enable=MC3A2.R17.6
>>  -enable=MC3A2.R18.1
>>  -enable=MC3A2.R18.2
>> +-enable=MC3A2.R18.3
>>  -enable=MC3A2.R18.6
>>  -enable=MC3A2.R18.8
>>  -enable=MC3A2.R19.1
>> @@ -83,14 +86,18 @@
>>  -enable=MC3A2.R20.14
>>  -enable=MC3A2.R21.3
>>  -enable=MC3A2.R21.4
>> --enable=MC3A2.R21.6
>>  -enable=MC3A2.R21.5
>> +-enable=MC3A2.R21.6
>>  -enable=MC3A2.R21.7
>>  -enable=MC3A2.R21.8
>>  -enable=MC3A2.R21.9
>>  -enable=MC3A2.R21.10
>> +-enable=MC3A2.R21.11
>>  -enable=MC3A2.R21.12
>>  -enable=MC3A2.R21.13
>> +-enable=MC3A2.R21.14
>> +-enable=MC3A2.R21.15
>> +-enable=MC3A2.R21.16
>>  -enable=MC3A2.R21.17
>>  -enable=MC3A2.R21.18
>>  -enable=MC3A2.R21.19
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.