x86/build: Remove leading space in xen.efi.S rule

[PATCH] x86/build: Remove leading space in xen.efi.S rule

Posted by Andrew Cooper 1 week, 5 days ago

It happens to be benign, but it causes emacs to ask:

  Suspicious line 194. Save anyway? (y or n)

whenever saving the file.

Fixes: da944a72fdf4 ("x86: split xen-syms/xen.efi linking rules")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monné <roger@xenproject.org>
CC: Teddy Astie <teddy.astie@vates.tech>
---
 xen/arch/x86/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index ee2573c2fb0f..8a205c3d27ff 100644
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -191,7 +191,7 @@ ifeq ($(XEN_BUILD_PE),y)
 .$(TARGET).efi.%s.S:
 	$(NM) -pa --format=sysv $< \
 	  | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \
- 	    --source-name=$(TARGET).efi.S \
+	    --source-name=$(TARGET).efi.S \
 	  > $@
 
 # See above for why $(note_file) needs removing here.

base-commit: 6bdb8d45b749a4f376d0380ff9503162b14b8468
-- 
2.39.5

Re: [PATCH] x86/build: Remove leading space in xen.efi.S rule

Posted by Jan Beulich 1 week, 3 days ago

On 11.09.2026 22:16, Andrew Cooper wrote:
> It happens to be benign, but it causes emacs to ask:
> 
>   Suspicious line 194. Save anyway? (y or n)
> 
> whenever saving the file.
> 
> Fixes: da944a72fdf4 ("x86: split xen-syms/xen.efi linking rules")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

No idea how that had slipped in.

Jan