[PATCH 0/3] x86: Fixes for not-quite-XSA in pci_conf_write_intercept()

Andrew Cooper posted 3 patches 2 weeks, 1 day ago
xen/arch/x86/include/asm/pci.h    |  5 ++---
xen/arch/x86/pci.c                |  6 ++----
xen/arch/x86/pv/emul-priv-op.c    | 10 +++++-----
xen/arch/x86/pv/ro-page-fault.c   | 18 ++++++++++--------
xen/arch/x86/x86_64/mmconfig_64.c | 18 ++++++++----------
xen/arch/x86/x86_64/pci.c         | 12 ++++++------
xen/include/xen/pci.h             |  8 ++++----
7 files changed, 37 insertions(+), 40 deletions(-)
[PATCH 0/3] x86: Fixes for not-quite-XSA in pci_conf_write_intercept()
Posted by Andrew Cooper 2 weeks, 1 day ago
Plumb pci_sbdf_t up and down the callchain to simplify parameter passing and
make it harder to forget the segment.

Andrew Cooper (3):
  x86/pv: Convert struct mmio_ro_emulate_ctxt to use pci_sbdf_t
  x86/pci: Convert pci_mmcfg_{read,write}() to use pci_sbdf_t
  x86/pci: Update pci_conf_write_intercept() to use pci_sbdf_t

 xen/arch/x86/include/asm/pci.h    |  5 ++---
 xen/arch/x86/pci.c                |  6 ++----
 xen/arch/x86/pv/emul-priv-op.c    | 10 +++++-----
 xen/arch/x86/pv/ro-page-fault.c   | 18 ++++++++++--------
 xen/arch/x86/x86_64/mmconfig_64.c | 18 ++++++++----------
 xen/arch/x86/x86_64/pci.c         | 12 ++++++------
 xen/include/xen/pci.h             |  8 ++++----
 7 files changed, 37 insertions(+), 40 deletions(-)


base-commit: a2ca4f8b9890899ca89d6116002e7a9c5957d8c6
-- 
2.39.5
Re: [PATCH 0/3] x86: Fixes for not-quite-XSA in pci_conf_write_intercept()
Posted by Teddy Astie 2 weeks, 1 day ago
Le 08/09/2026 à 23:57, Andrew Cooper a écrit :
> Plumb pci_sbdf_t up and down the callchain to simplify parameter passing and
> make it harder to forget the segment.
> 
> Andrew Cooper (3):
>    x86/pv: Convert struct mmio_ro_emulate_ctxt to use pci_sbdf_t
>    x86/pci: Convert pci_mmcfg_{read,write}() to use pci_sbdf_t
>    x86/pci: Update pci_conf_write_intercept() to use pci_sbdf_t
> 
>   xen/arch/x86/include/asm/pci.h    |  5 ++---
>   xen/arch/x86/pci.c                |  6 ++----
>   xen/arch/x86/pv/emul-priv-op.c    | 10 +++++-----
>   xen/arch/x86/pv/ro-page-fault.c   | 18 ++++++++++--------
>   xen/arch/x86/x86_64/mmconfig_64.c | 18 ++++++++----------
>   xen/arch/x86/x86_64/pci.c         | 12 ++++++------
>   xen/include/xen/pci.h             |  8 ++++----
>   7 files changed, 37 insertions(+), 40 deletions(-)
> 
> 
> base-commit: a2ca4f8b9890899ca89d6116002e7a9c5957d8c6

Reviewed-by: Teddy Astie <teddy.astie@vates.tech>
Re: [PATCH 0/3] x86: Fixes for not-quite-XSA in pci_conf_write_intercept()
Posted by Jan Beulich 2 weeks, 1 day ago
On 08.09.2026 23:57, Andrew Cooper wrote:
> Plumb pci_sbdf_t up and down the callchain to simplify parameter passing and
> make it harder to forget the segment.
> 
> Andrew Cooper (3):
>   x86/pv: Convert struct mmio_ro_emulate_ctxt to use pci_sbdf_t
>   x86/pci: Convert pci_mmcfg_{read,write}() to use pci_sbdf_t
>   x86/pci: Update pci_conf_write_intercept() to use pci_sbdf_t

Reviewed-by: Jan Beulich <jbeulich@suse.com>
Re: [PATCH 0/3] x86: Fixes for not-quite-XSA in pci_conf_write_intercept()
Posted by Andrew Cooper 2 weeks, 1 day ago
On 09/09/2026 7:39 am, Jan Beulich wrote:
> On 08.09.2026 23:57, Andrew Cooper wrote:
>> Plumb pci_sbdf_t up and down the callchain to simplify parameter passing and
>> make it harder to forget the segment.
>>
>> Andrew Cooper (3):
>>   x86/pv: Convert struct mmio_ro_emulate_ctxt to use pci_sbdf_t
>>   x86/pci: Convert pci_mmcfg_{read,write}() to use pci_sbdf_t
>>   x86/pci: Update pci_conf_write_intercept() to use pci_sbdf_t
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>

Thanks.

It's worth saying that there's also some cleanup to XSM wanting to
happen, but I'm going to wait until your series is fully in before even
starting to look at that.

~Andrew