This series corrects Argo module tracing.

Patch 1 lowers the verbosity of a spammy log message.
Patch 2 corrects the debug logline.
Patch 3 cleans up existing loglines by dropping duplicate prefixes.
Patch 4 re-wires argo_dprintk() to gprintk() to include mode debugging
        context.
Patch 5 adds new Kconfig for short-circuiting extra verbose Argo traces.
Patch 6 enables extra verbose Argo traces in CI for ease of catching
        potential issues.

CI: https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2577682899
Link to v5: https://lore.kernel.org/xen-devel/20260603194131.1468654-1-dmukhin@ford.com/

Denis Mukhin (6):
  argo: lower level of noisy connection-refused log
  argo: correct logline in ring_unmap()
  argo: drop argo prefix from argo_dprintk() calls
  argo: fixup argo_dprintk()
  argo: introduce CONFIG_ARGO_DEBUG
  automation: enable Argo debugging in CI

 automation/gitlab-ci/analyze.yaml |  2 ++
 automation/gitlab-ci/build.yaml   |  1 +
 xen/common/Kconfig                |  6 ++++++
 xen/common/argo.c                 | 22 ++++++++++------------
 4 files changed, 19 insertions(+), 12 deletions(-)

-- 
2.54.0

On Thu, Jun 4, 2026 at 10:49 PM <dmukhin@ford.com> wrote:
>
> This series corrects Argo module tracing.

This series has been committed to staging.

The maintainers were not CC'd on the series, and did not provide an ack.

Patch 1 is rejected as an inappropriate change.

Therefore it needs reverting.

> Patch 1 lowers the verbosity of a spammy log message.

Please see the review comment provided by Daniel on the v3 version.

thanks

Christopher

Hi all,

On Mon, Jun 08, 2026 at 10:49:55PM +0100, Christopher Clark wrote:
> On Thu, Jun 4, 2026 at 10:49 PM <dmukhin@ford.com> wrote:
> >
> > This series corrects Argo module tracing.
> 
> This series has been committed to staging.
> 
> The maintainers were not CC'd on the series, and did not provide an ack.

Sorry, I did not mean to overrule anything or violate the existing process.

I posted the series as an attempt to resolve the log spam reported internally.

I also appreciate the time everyone involved spent reviewing and providing
feedback on this small series.

> 
> Patch 1 is rejected as an inappropriate change.
> 
> Therefore it needs reverting.
> 
> > Patch 1 lowers the verbosity of a spammy log message.
> 
> Please see the review comment provided by Daniel on the v3 version.
> 
> thanks
> 
> Christopher
> 


--
Denis

On 2026-06-08 17:49, Christopher Clark wrote:
> On Thu, Jun 4, 2026 at 10:49 PM <dmukhin@ford.com> wrote:
>>
>> This series corrects Argo module tracing.
> 
> This series has been committed to staging.
> 
> The maintainers were not CC'd on the series, and did not provide an ack.
> 
> Patch 1 is rejected as an inappropriate change.
> 
> Therefore it needs reverting.
> 
>> Patch 1 lowers the verbosity of a spammy log message.
> 
> Please see the review comment provided by Daniel on the v3 version.

FWIW, this comment to v3 was only posted today after v6 was commited. 
It was not an unaddressed comment at the time of commit.

Regards,
Jason

On 08/06/2026 10:49 pm, Christopher Clark wrote:
> On Thu, Jun 4, 2026 at 10:49 PM <dmukhin@ford.com> wrote:
>> This series corrects Argo module tracing.
> This series has been committed to staging.
>
> The maintainers were not CC'd on the series, and did not provide an ack.
>
> Patch 1 is rejected as an inappropriate change.
>
> Therefore it needs reverting.

Hmm yes, that was committed in violation of policy.

~Andrew

On 04.06.2026 23:49, dmukhin@ford.com wrote:
> This series corrects Argo module tracing.
> 
> Patch 1 lowers the verbosity of a spammy log message.
> Patch 2 corrects the debug logline.
> Patch 3 cleans up existing loglines by dropping duplicate prefixes.
> Patch 4 re-wires argo_dprintk() to gprintk() to include mode debugging
>         context.
> Patch 5 adds new Kconfig for short-circuiting extra verbose Argo traces.
> Patch 6 enables extra verbose Argo traces in CI for ease of catching
>         potential issues.
> 
> CI: https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2577682899
> Link to v5: https://lore.kernel.org/xen-devel/20260603194131.1468654-1-dmukhin@ford.com/
> 
> Denis Mukhin (6):
>   argo: lower level of noisy connection-refused log
>   argo: correct logline in ring_unmap()
>   argo: drop argo prefix from argo_dprintk() calls
>   argo: fixup argo_dprintk()
>   argo: introduce CONFIG_ARGO_DEBUG
>   automation: enable Argo debugging in CI

I understand you want to be helpful with sending these updates in rapid succession.
Yet as (attempted to) hint(ed) at before, please either do it properly or leave it
at "committer can do minor adjustments", when that was offered. This time round you
lost Oleksii's R-a-b. But no, please _do not_ send a v7 for that.

Jan

On Fri, Jun 05, 2026 at 08:23:18AM +0200, Jan Beulich wrote:
> On 04.06.2026 23:49, dmukhin@ford.com wrote:
> > This series corrects Argo module tracing.
> > 
> > Patch 1 lowers the verbosity of a spammy log message.
> > Patch 2 corrects the debug logline.
> > Patch 3 cleans up existing loglines by dropping duplicate prefixes.
> > Patch 4 re-wires argo_dprintk() to gprintk() to include mode debugging
> >         context.
> > Patch 5 adds new Kconfig for short-circuiting extra verbose Argo traces.
> > Patch 6 enables extra verbose Argo traces in CI for ease of catching
> >         potential issues.
> > 
> > CI: https://gitlab.com/xen-project/people/dmukhin/xen/-/pipelines/2577682899
> > Link to v5: https://lore.kernel.org/xen-devel/20260603194131.1468654-1-dmukhin@ford.com/
> > 
> > Denis Mukhin (6):
> >   argo: lower level of noisy connection-refused log
> >   argo: correct logline in ring_unmap()
> >   argo: drop argo prefix from argo_dprintk() calls
> >   argo: fixup argo_dprintk()
> >   argo: introduce CONFIG_ARGO_DEBUG
> >   automation: enable Argo debugging in CI
> 
> I understand you want to be helpful with sending these updates in rapid succession.
> Yet as (attempted to) hint(ed) at before, please either do it properly or leave it
> at "committer can do minor adjustments", when that was offered. This time round you
> lost Oleksii's R-a-b. But no, please _do not_ send a v7 for that.

Thanks for help with the series!

--
Denis