1. Patchew
  2. Xen
  3. View series

[PATCH] xen/sched: fix stale file path comments in common/sched directory

Furkan Caliskan posted 1 patch 5 days ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20260525102539.27050-1-frn1furkan10@gmail.com
xen/common/sched/arinc653.c     | 2 +-
xen/common/sched/boot-cpupool.c | 2 +-
xen/common/sched/compat.c       | 2 +-
xen/common/sched/core.c         | 2 +-
xen/common/sched/cpupool.c      | 2 +-
xen/common/sched/credit.c       | 2 +-
xen/common/sched/credit2.c      | 2 +-
xen/common/sched/null.c         | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
[PATCH] xen/sched: fix stale file path comments in common/sched directory
Posted by Furkan Caliskan 5 days ago 
Commit 6cb4b01c03 ("xen/sched: move schedulers and cpupool coding to
dedicated directory") moved the scheduler files from xen/common/ to
xen/common/sched and renamed some of them, but did not update the
in-file path comments at the top of each file.

Update the comments to reflect the current file locations.

Signed-off-by: Furkan Caliskan <frn1furkan10@gmail.com>
---
 xen/common/sched/arinc653.c     | 2 +-
 xen/common/sched/boot-cpupool.c | 2 +-
 xen/common/sched/compat.c       | 2 +-
 xen/common/sched/core.c         | 2 +-
 xen/common/sched/cpupool.c      | 2 +-
 xen/common/sched/credit.c       | 2 +-
 xen/common/sched/credit2.c      | 2 +-
 xen/common/sched/null.c         | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c
index d8a5380557..f509915e9b 100644
--- a/xen/common/sched/arinc653.c
+++ b/xen/common/sched/arinc653.c
@@ -1,5 +1,5 @@
 /******************************************************************************
- * sched_arinc653.c
+ * common/sched/arinc653.c
  *
  * An ARINC653-compatible scheduling algorithm for use in Xen.
  *
diff --git a/xen/common/sched/boot-cpupool.c b/xen/common/sched/boot-cpupool.c
index 03be73efdd..38beec8ec7 100644
--- a/xen/common/sched/boot-cpupool.c
+++ b/xen/common/sched/boot-cpupool.c
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 /*
- * xen/common/boot_cpupools.c
+ * common/sched/boot-cpupool.c
  *
  * Code to create cpupools at boot time.
  *
diff --git a/xen/common/sched/compat.c b/xen/common/sched/compat.c
index a02204ec9a..1bbbd8f717 100644
--- a/xen/common/sched/compat.c
+++ b/xen/common/sched/compat.c
@@ -1,5 +1,5 @@
 /****************************************************************************
- * schedule.c
+ * common/sched/compat.c
  *
  */
 
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index a57d5dd929..e4577d41f7 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -4,7 +4,7 @@
  * (C) 2004      - Mark Williamson - Intel Research Cambridge
  ****************************************************************************
  *
- *        File: common/schedule.c
+ *        File: common/sched/core.c
  *      Author: Rolf Neugebauer & Keir Fraser
  *              Updated for generic API by Mark Williamson
  *
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index f5459c2779..b1e0884842 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1,5 +1,5 @@
 /******************************************************************************
- * cpupool.c
+ * common/sched/cpupool.c
  * 
  * Generic cpupool-handling functions.
  *
diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c
index e9a91d11c3..9c8075338e 100644
--- a/xen/common/sched/credit.c
+++ b/xen/common/sched/credit.c
@@ -2,7 +2,7 @@
  * (C) 2005-2006 - Emmanuel Ackaouy - XenSource Inc.
  ****************************************************************************
  *
- *        File: common/csched_credit.c
+ *        File: common/sched/credit.c
  *      Author: Emmanuel Ackaouy
  *
  * Description: Credit-based SMP CPU scheduler
diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index 75316d42b7..04e7b9a28c 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -3,7 +3,7 @@
  * (C) 2009 - George Dunlap - Citrix Systems R&D UK, Ltd
  ****************************************************************************
  *
- *        File: common/sched_credit2.c
+ *        File: common/sched/credit2.c
  *      Author: George Dunlap
  *
  * Description: Credit-based SMP CPU scheduler
diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c
index c8e327e3cd..aa136fa729 100644
--- a/xen/common/sched/null.c
+++ b/xen/common/sched/null.c
@@ -1,5 +1,5 @@
 /*
- * xen/common/sched_null.c
+ * common/sched/null.c
  *
  *  Copyright (c) 2017, Dario Faggioli, Citrix Ltd
  *
-- 
2.34.1
Re: [PATCH] xen/sched: fix stale file path comments in common/sched directory
Posted by Roger Pau Monné 4 days, 23 hours ago 
On Mon, May 25, 2026 at 01:25:38PM +0300, Furkan Caliskan wrote:
> Commit 6cb4b01c03 ("xen/sched: move schedulers and cpupool coding to
> dedicated directory") moved the scheduler files from xen/common/ to
> xen/common/sched and renamed some of them, but did not update the
> in-file path comments at the top of each file.
> 
> Update the comments to reflect the current file locations.

FWIW, if we have to modify those lines I would just delete them, I
don't think they add anything meaningful to the file.

Thanks, Roger.
Re: [PATCH] xen/sched: fix stale file path comments in common/sched directory
Posted by Jürgen Groß 4 days, 4 hours ago 
On 25.05.26 12:58, Roger Pau Monné wrote:
> On Mon, May 25, 2026 at 01:25:38PM +0300, Furkan Caliskan wrote:
>> Commit 6cb4b01c03 ("xen/sched: move schedulers and cpupool coding to
>> dedicated directory") moved the scheduler files from xen/common/ to
>> xen/common/sched and renamed some of them, but did not update the
>> in-file path comments at the top of each file.
>>
>> Update the comments to reflect the current file locations.
> 
> FWIW, if we have to modify those lines I would just delete them, I
> don't think they add anything meaningful to the file.

Wanted to write the same. So yes, please drop the lines instead of
modifying them.


Juergen
Re: [PATCH] xen/sched: fix stale file path comments in common/sched directory
Posted by Furkan Çalışkan 4 days, 4 hours ago 
On 5/26/26 09:18, Jürgen Groß wrote:
> On 25.05.26 12:58, Roger Pau Monné wrote:
>> On Mon, May 25, 2026 at 01:25:38PM +0300, Furkan Caliskan wrote:
>>> Commit 6cb4b01c03 ("xen/sched: move schedulers and cpupool coding to
>>> dedicated directory") moved the scheduler files from xen/common/ to
>>> xen/common/sched and renamed some of them, but did not update the
>>> in-file path comments at the top of each file.
>>>
>>> Update the comments to reflect the current file locations.
>>
>> FWIW, if we have to modify those lines I would just delete them, I
>> don't think they add anything meaningful to the file.
> 
> Wanted to write the same. So yes, please drop the lines instead of
> modifying them.
> 
> 
> Juergen

Thanks for the feedback. I'll send a v2 with the lines dropped. 

Furkan Caliskan
[PATCH v2] xen/sched: remove stale file path comments in common/sched directory
Posted by Furkan Caliskan 4 days, 2 hours ago 
Commit 6cb4b01c03 ("xen/sched: move schedulers and cpupool coding to
dedicated directory") moved the scheduler files from xen/common/ to
xen/common/sched and renamed some of them, but did not update the
in-file path comments at the top of each file.

Remove the comments rather than updating them, as they are redundant
information already conveyed by the filename itself.

Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
Suggested-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Furkan Caliskan <frn1furkan10@gmail.com>
---
 xen/common/sched/arinc653.c     | 1 -
 xen/common/sched/boot-cpupool.c | 2 --
 xen/common/sched/compat.c       | 4 ----
 xen/common/sched/core.c         | 1 -
 xen/common/sched/cpupool.c      | 1 -
 xen/common/sched/credit.c       | 1 -
 xen/common/sched/credit2.c      | 1 -
 xen/common/sched/null.c         | 1 -
 8 files changed, 12 deletions(-)

diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c
index d8a5380557..32c596a23c 100644
--- a/xen/common/sched/arinc653.c
+++ b/xen/common/sched/arinc653.c
@@ -1,5 +1,4 @@
 /******************************************************************************
- * sched_arinc653.c
  *
  * An ARINC653-compatible scheduling algorithm for use in Xen.
  *
diff --git a/xen/common/sched/boot-cpupool.c b/xen/common/sched/boot-cpupool.c
index 03be73efdd..3ffe1f26bd 100644
--- a/xen/common/sched/boot-cpupool.c
+++ b/xen/common/sched/boot-cpupool.c
@@ -1,7 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 /*
- * xen/common/boot_cpupools.c
- *
  * Code to create cpupools at boot time.
  *
  * Copyright (C) 2022 Arm Ltd.
diff --git a/xen/common/sched/compat.c b/xen/common/sched/compat.c
index a02204ec9a..5574393cb4 100644
--- a/xen/common/sched/compat.c
+++ b/xen/common/sched/compat.c
@@ -1,7 +1,3 @@
-/****************************************************************************
- * schedule.c
- *
- */
 
 #ifndef __COMMON_SCHED_COMPAT_C__
 #define __COMMON_SCHED_COMPAT_C__
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index a57d5dd929..8e2b75bc35 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -4,7 +4,6 @@
  * (C) 2004      - Mark Williamson - Intel Research Cambridge
  ****************************************************************************
  *
- *        File: common/schedule.c
  *      Author: Rolf Neugebauer & Keir Fraser
  *              Updated for generic API by Mark Williamson
  *
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index f5459c2779..081e1053eb 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1,5 +1,4 @@
 /******************************************************************************
- * cpupool.c
  * 
  * Generic cpupool-handling functions.
  *
diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c
index e9a91d11c3..07656a57e9 100644
--- a/xen/common/sched/credit.c
+++ b/xen/common/sched/credit.c
@@ -2,7 +2,6 @@
  * (C) 2005-2006 - Emmanuel Ackaouy - XenSource Inc.
  ****************************************************************************
  *
- *        File: common/csched_credit.c
  *      Author: Emmanuel Ackaouy
  *
  * Description: Credit-based SMP CPU scheduler
diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index 75316d42b7..77475ee363 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -3,7 +3,6 @@
  * (C) 2009 - George Dunlap - Citrix Systems R&D UK, Ltd
  ****************************************************************************
  *
- *        File: common/sched_credit2.c
  *      Author: George Dunlap
  *
  * Description: Credit-based SMP CPU scheduler
diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c
index c8e327e3cd..5f15779b07 100644
--- a/xen/common/sched/null.c
+++ b/xen/common/sched/null.c
@@ -1,5 +1,4 @@
 /*
- * xen/common/sched_null.c
  *
  *  Copyright (c) 2017, Dario Faggioli, Citrix Ltd
  *
-- 
2.34.1
Re: [PATCH v2] xen/sched: remove stale file path comments in common/sched directory
Posted by Jürgen Groß 4 days ago 
On 26.05.26 09:52, Furkan Caliskan wrote:
> Commit 6cb4b01c03 ("xen/sched: move schedulers and cpupool coding to
> dedicated directory") moved the scheduler files from xen/common/ to
> xen/common/sched and renamed some of them, but did not update the
> in-file path comments at the top of each file.
> 
> Remove the comments rather than updating them, as they are redundant
> information already conveyed by the filename itself.
> 
> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
> Suggested-by: Juergen Gross <jgross@suse.com>
> Signed-off-by: Furkan Caliskan <frn1furkan10@gmail.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen
Re: [PATCH v2] xen/sched: remove stale file path comments in common/sched directory
Posted by Stewart Hildebrand 2 days, 14 hours ago 
On 5/26/26 06:09, Jürgen Groß wrote:
> On 26.05.26 09:52, Furkan Caliskan wrote:
>> Commit 6cb4b01c03 ("xen/sched: move schedulers and cpupool coding to
>> dedicated directory") moved the scheduler files from xen/common/ to
>> xen/common/sched and renamed some of them, but did not update the
>> in-file path comments at the top of each file.
>>
>> Remove the comments rather than updating them, as they are redundant
>> information already conveyed by the filename itself.
>>
>> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
>> Suggested-by: Juergen Gross <jgross@suse.com>
>> Signed-off-by: Furkan Caliskan <frn1furkan10@gmail.com>
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>

For ARINC 653:
Acked-by: Stewart Hildebrand <stewart.hildebrand@amd.com>

FYI, we are in the release cycle for 4.22, and I'm not sure this is justified to
be included in this release. IMO it would be OK to wait for the next cycle.
Re: [PATCH v2] xen/sched: remove stale file path comments in common/sched directory
Posted by Andrew Cooper 2 days ago 
On 27/05/2026 8:51 pm, Stewart Hildebrand wrote:
> On 5/26/26 06:09, Jürgen Groß wrote:
>> On 26.05.26 09:52, Furkan Caliskan wrote:
>>> Commit 6cb4b01c03 ("xen/sched: move schedulers and cpupool coding to
>>> dedicated directory") moved the scheduler files from xen/common/ to
>>> xen/common/sched and renamed some of them, but did not update the
>>> in-file path comments at the top of each file.
>>>
>>> Remove the comments rather than updating them, as they are redundant
>>> information already conveyed by the filename itself.
>>>
>>> Suggested-by: Roger Pau Monné <roger.pau@citrix.com>
>>> Suggested-by: Juergen Gross <jgross@suse.com>
>>> Signed-off-by: Furkan Caliskan <frn1furkan10@gmail.com>
>> Reviewed-by: Juergen Gross <jgross@suse.com>
> For ARINC 653:
> Acked-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
>
> FYI, we are in the release cycle for 4.22, and I'm not sure this is justified to
> be included in this release. IMO it would be OK to wait for the next cycle.

Bugfixes are still being accepted, and wrong comments are a bug.  I've
taken the patch.

~Andrew

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.