1. Patchew
  2. Xen
  3. View series

[PATCH v2] x86/dom0: enable pf-fixup by default for PVH dom0

Roger Pau Monne posted 1 patch 2 weeks, 4 days ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20260511185145.23750-1-roger.pau@citrix.com
CHANGELOG.md                      | 2 ++
docs/misc/xen-command-line.pandoc | 8 ++++++--
xen/arch/x86/hvm/emulate.c        | 2 +-
3 files changed, 9 insertions(+), 3 deletions(-)
[PATCH v2] x86/dom0: enable pf-fixup by default for PVH dom0
Posted by Roger Pau Monne 2 weeks, 4 days ago 
A non-trivial amount of issues related to PVH dom0 are fixed by enabling
the `pf-fixup` command line option, and no issues have been reported as a
result of its usage.  Enable the option by default to make PVH dom0 more
robust in its default configuration.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Slightly reword an expand option help text.
 - Mention the change of defaults in CHANGELOG.
---
 CHANGELOG.md                      | 2 ++
 docs/misc/xen-command-line.pandoc | 8 ++++++--
 xen/arch/x86/hvm/emulate.c        | 2 +-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ce46020dbdb4..25f5a192ed48 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 ## [4.22.0 UNRELEASED](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD
 
 ### Changed
+ - On x86:
+   - Enable pf-fixup option by default for PVH dom0.
 
 ### Added
  - Support for per-domain Xenstore quota in C xenstored (includes
diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 6c77129732bf..2da90548d8fb 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -849,7 +849,7 @@ Controls for how dom0 is constructed on x86 systems.
     If using this option is necessary to fix an issue, please report a bug.
 
 *   The `pf-fixup` boolean is only applicable when using a PVH dom0 and
-    defaults to false.
+    defaults to true.
 
     When running dom0 in PVH mode the dom0 kernel has no way to map MMIO
     regions into its physical memory map, such mode relies on Xen dom0 builder
@@ -857,10 +857,14 @@ Controls for how dom0 is constructed on x86 systems.
     access.  However Xen doesn't have a complete picture of the host memory
     map, due to not being able to process ACPI dynamic tables.
 
-    The `pf-fixup` option allows Xen to attempt to add missing MMIO regions
+    The `pf-fixup` option causes Xen to attempt to add missing MMIO regions
     to the dom0 physical memory map in response to page-faults generated by
     dom0 trying to access unpopulated entries in the memory map.
 
+    Users having to disable the feature to boot in PVH dom0 mode should report
+    it to the xen-devel mailing list, together with Xen and dom0 output with the
+    option enabled.
+
 Enables features on dom0 on Arm systems.
 
 *   The `sve` integer parameter enables Arm SVE usage for Dom0 and sets the
diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
index f3aae158e9f8..bb1bb03ac4e9 100644
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -165,7 +165,7 @@ void hvmemul_cancel(struct vcpu *v)
     hvmemul_cache_disable(v);
 }
 
-bool __ro_after_init opt_dom0_pf_fixup;
+bool __ro_after_init opt_dom0_pf_fixup = true;
 static int hwdom_fixup_p2m(paddr_t addr)
 {
     unsigned long gfn = paddr_to_pfn(addr);
-- 
2.53.0
Re: [PATCH v2] x86/dom0: enable pf-fixup by default for PVH dom0
Posted by Oleksii Kurochko 2 weeks, 3 days ago 

On 5/11/26 8:51 PM, Roger Pau Monne wrote:
> A non-trivial amount of issues related to PVH dom0 are fixed by enabling
> the `pf-fixup` command line option, and no issues have been reported as a
> result of its usage.  Enable the option by default to make PVH dom0 more
> robust in its default configuration.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Changes since v1:
>   - Slightly reword an expand option help text.
>   - Mention the change of defaults in CHANGELOG.
> ---
>   CHANGELOG.md                      | 2 ++
>   docs/misc/xen-command-line.pandoc | 8 ++++++--
>   xen/arch/x86/hvm/emulate.c        | 2 +-
>   3 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index ce46020dbdb4..25f5a192ed48 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -7,6 +7,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>   ## [4.22.0 UNRELEASED](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD
>   
>   ### Changed
> + - On x86:
> +   - Enable pf-fixup option by default for PVH dom0.

LGTM:
  Acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

And also,
  Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

Thanks.

~ Oleksii
Re: [PATCH v2] x86/dom0: enable pf-fixup by default for PVH dom0
Posted by Jan Beulich 2 weeks, 4 days ago 
On 11.05.2026 20:51, Roger Pau Monne wrote:
> A non-trivial amount of issues related to PVH dom0 are fixed by enabling
> the `pf-fixup` command line option, and no issues have been reported as a
> result of its usage.  Enable the option by default to make PVH dom0 more
> robust in its default configuration.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.