x86/pdx: Undef the correct macro

[PATCH] x86/pdx: Undef the correct macro

Posted by Andrew Cooper 2 days, 4 hours ago

This was caused by a renamne during review.

No functional change.

Reported-by: Luca Fancellu <luca.fancellu@arm.com>
Fixes: bd0b3a876d80 ("pdx: allow per-arch optimization of PDX conversion helpers")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Teddy Astie <teddy.astie@vates.tech>
CC: Luca Fancellu <luca.fancellu@arm.com>
---
 xen/arch/x86/include/asm/pdx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/include/asm/pdx.h b/xen/arch/x86/include/asm/pdx.h
index 6be7e1185eb1..6c10234ecfa9 100644
--- a/xen/arch/x86/include/asm/pdx.h
+++ b/xen/arch/x86/include/asm/pdx.h
@@ -57,7 +57,7 @@ static inline paddr_t directmapoff_to_maddr(unsigned long offset)
     return offset;
 }
 
-#undef PDX_ASM_GOTO_SKIP
+#undef PDX_ASM_GOTO
 
 #endif /* X86_PDX_H */
 
-- 
2.39.5

Re: [PATCH] x86/pdx: Undef the correct macro

Posted by Luca Fancellu 2 days, 4 hours ago

Hi Andrew,

> On 1 May 2026, at 09:40, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> 
> This was caused by a renamne during review.

NIT: Typo s/renamne/rename/

> 
> No functional change.
> 
> Reported-by: Luca Fancellu <luca.fancellu@arm.com>
> Fixes: bd0b3a876d80 ("pdx: allow per-arch optimization of PDX conversion helpers")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Teddy Astie <teddy.astie@vates.tech>
> CC: Luca Fancellu <luca.fancellu@arm.com>
> ---
> xen/arch/x86/include/asm/pdx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/include/asm/pdx.h b/xen/arch/x86/include/asm/pdx.h
> index 6be7e1185eb1..6c10234ecfa9 100644
> --- a/xen/arch/x86/include/asm/pdx.h
> +++ b/xen/arch/x86/include/asm/pdx.h
> @@ -57,7 +57,7 @@ static inline paddr_t directmapoff_to_maddr(unsigned long offset)
>     return offset;
> }
> 
> -#undef PDX_ASM_GOTO_SKIP
> +#undef PDX_ASM_GOTO
> 
> #endif /* X86_PDX_H */
> 
> -- 
> 2.39.5
> 

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

Cheers,
Luca

Re: [PATCH] x86/pdx: Undef the correct macro

Posted by Andrew Cooper 2 days, 4 hours ago

On 01/05/2026 9:42 am, Luca Fancellu wrote:
> Hi Andrew,
>
>> On 1 May 2026, at 09:40, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>>
>> This was caused by a renamne during review.
> NIT: Typo s/renamne/rename/

Oops.  I need more coffee.

>
>> No functional change.
>>
>> Reported-by: Luca Fancellu <luca.fancellu@arm.com>
>> Fixes: bd0b3a876d80 ("pdx: allow per-arch optimization of PDX conversion helpers")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Jan Beulich <jbeulich@suse.com>
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>> CC: Teddy Astie <teddy.astie@vates.tech>
>> CC: Luca Fancellu <luca.fancellu@arm.com>
>> ---
>> xen/arch/x86/include/asm/pdx.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/x86/include/asm/pdx.h b/xen/arch/x86/include/asm/pdx.h
>> index 6be7e1185eb1..6c10234ecfa9 100644
>> --- a/xen/arch/x86/include/asm/pdx.h
>> +++ b/xen/arch/x86/include/asm/pdx.h
>> @@ -57,7 +57,7 @@ static inline paddr_t directmapoff_to_maddr(unsigned long offset)
>>     return offset;
>> }
>>
>> -#undef PDX_ASM_GOTO_SKIP
>> +#undef PDX_ASM_GOTO
>>
>> #endif /* X86_PDX_H */
>>
>> -- 
>> 2.39.5
>>
> Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

Thanks.

~Andrew