[PATCH v2 0/8] tools/xs-clients: add some man pages and fixes

Juergen Gross posted 8 patches 1 week, 4 days ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20260312155102.2862824-1-jgross@suse.com
docs/man/xenstore-chmod.1.pod      |  4 +++
docs/man/xenstore-exists.1.pod     | 25 ++++++++++++++++
docs/man/xenstore-list.1.pod       | 28 +++++++++++++++++
docs/man/xenstore-ls.1.pod         |  4 +++
docs/man/xenstore-read.1.pod       |  4 +++
docs/man/xenstore-rm.1.pod         | 28 +++++++++++++++++
docs/man/xenstore-watch.1.pod      | 29 ++++++++++++++++++
docs/man/xenstore-write.1.pod      |  4 +++
tools/xs-clients/xenstore_client.c | 48 ++++++++++++++++--------------
9 files changed, 152 insertions(+), 22 deletions(-)
create mode 100644 docs/man/xenstore-exists.1.pod
create mode 100644 docs/man/xenstore-list.1.pod
create mode 100644 docs/man/xenstore-rm.1.pod
create mode 100644 docs/man/xenstore-watch.1.pod
[PATCH v2 0/8] tools/xs-clients: add some man pages and fixes
Posted by Juergen Gross 1 week, 4 days ago
For some of the Xenstore client programs the man pages are missing
entirely, the existing man pages don't mention the "-h" parameter.

Additionally fix some other minor bugs in the code. Those bugs seem
to exist since roughly 20 years now, so I didn't do a thorough
archaeological examination for finding the exact commits introducing
them, as any potential backport candidate will need to go to all
still supported Xen versions anyway.

Changes in V2:
- new patches 1 and 6-8
- some small fixes in the other patches

Juergen Gross (8):
  docs: add -h parameter description to xenstore-* man pages
  docs: add man page for xenstore-exists
  docs: add man page for xenstore-list
  docs: add man page for xenstore-rm
  docs: add man page for xenstore-watch
  tools/xs-clients: don't exit with error when using -h parameter
  tools/xs-clients: fix usage information of xenstore-exists
  tools/xs-clients: fix output of "xenstore-list -p /"

 docs/man/xenstore-chmod.1.pod      |  4 +++
 docs/man/xenstore-exists.1.pod     | 25 ++++++++++++++++
 docs/man/xenstore-list.1.pod       | 28 +++++++++++++++++
 docs/man/xenstore-ls.1.pod         |  4 +++
 docs/man/xenstore-read.1.pod       |  4 +++
 docs/man/xenstore-rm.1.pod         | 28 +++++++++++++++++
 docs/man/xenstore-watch.1.pod      | 29 ++++++++++++++++++
 docs/man/xenstore-write.1.pod      |  4 +++
 tools/xs-clients/xenstore_client.c | 48 ++++++++++++++++--------------
 9 files changed, 152 insertions(+), 22 deletions(-)
 create mode 100644 docs/man/xenstore-exists.1.pod
 create mode 100644 docs/man/xenstore-list.1.pod
 create mode 100644 docs/man/xenstore-rm.1.pod
 create mode 100644 docs/man/xenstore-watch.1.pod

-- 
2.53.0
Re: [PATCH v2 0/8] tools/xs-clients: add some man pages and fixes
Posted by Andrew Cooper 1 week, 4 days ago
On 12/03/2026 3:50 pm, Juergen Gross wrote:
> Juergen Gross (8):
>   docs: add -h parameter description to xenstore-* man pages
>   docs: add man page for xenstore-exists
>   docs: add man page for xenstore-list
>   docs: add man page for xenstore-rm
>   docs: add man page for xenstore-watch
>   tools/xs-clients: don't exit with error when using -h parameter
>   tools/xs-clients: fix usage information of xenstore-exists
>   tools/xs-clients: fix output of "xenstore-list -p /"

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Two minor comments, both of which I can fix on commit if you're happy? 
(With the patch 6 knock-on to patch 7).

~Andrew

Re: [PATCH v2 0/8] tools/xs-clients: add some man pages and fixes
Posted by Juergen Gross 1 week, 4 days ago
On 12.03.26 17:02, Andrew Cooper wrote:
> On 12/03/2026 3:50 pm, Juergen Gross wrote:
>> Juergen Gross (8):
>>    docs: add -h parameter description to xenstore-* man pages
>>    docs: add man page for xenstore-exists
>>    docs: add man page for xenstore-list
>>    docs: add man page for xenstore-rm
>>    docs: add man page for xenstore-watch
>>    tools/xs-clients: don't exit with error when using -h parameter
>>    tools/xs-clients: fix usage information of xenstore-exists
>>    tools/xs-clients: fix output of "xenstore-list -p /"
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks.

> 
> Two minor comments, both of which I can fix on commit if you're happy?
> (With the patch 6 knock-on to patch 7).

Yes, sure.


Juergen