On 2026-02-20 22:46, Andrew Cooper wrote:
> sh_destroy_shadow() has a spelling of fallthrough which doesn't match
> the
> permitted pattern. Convert it to a real fallthrough (psedo)keyword.
>
> Elsewhere, insert breaks at the end of the default statements.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien@xen.org>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> CC: Bertrand Marquis <bertrand.marquis@arm.com>
> CC: Michal Orzel <michal.orzel@amd.com>
> CC: consulting@bugseng.com <consulting@bugseng.com>
> CC: Nicola Vetrini <nicola.vetrini@bugseng.com>
> ---
> xen/arch/arm/pci/pci-access.c | 2 ++
> xen/arch/arm/pci/pci-designware.c | 2 ++
> xen/arch/arm/tee/optee.c | 1 +
> xen/arch/x86/mm/shadow/common.c | 2 +-
> 4 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/pci/pci-access.c
> b/xen/arch/arm/pci/pci-access.c
> index c0533c00c9a5..2b23d552bbfb 100644
> --- a/xen/arch/arm/pci/pci-access.c
> +++ b/xen/arch/arm/pci/pci-access.c
> @@ -63,6 +63,7 @@ int pci_generic_config_read(struct pci_host_bridge
> *bridge, pci_sbdf_t sbdf,
> break;
> default:
> ASSERT_UNREACHABLE();
> + break;
> }
>
> return 0;
> @@ -89,6 +90,7 @@ int pci_generic_config_write(struct pci_host_bridge
> *bridge, pci_sbdf_t sbdf,
> break;
> default:
> ASSERT_UNREACHABLE();
> + break;
> }
>
> return 0;
> diff --git a/xen/arch/arm/pci/pci-designware.c
> b/xen/arch/arm/pci/pci-designware.c
> index 6b85213f637b..902da19e8c98 100644
> --- a/xen/arch/arm/pci/pci-designware.c
> +++ b/xen/arch/arm/pci/pci-designware.c
> @@ -48,6 +48,7 @@ static int dw_pcie_read(void __iomem *addr, unsigned
> int len, uint32_t *val)
> break;
> default:
> ASSERT_UNREACHABLE();
> + break;
> }
>
> return 0;
> @@ -71,6 +72,7 @@ static int dw_pcie_write(void __iomem *addr, unsigned
> int len, uint32_t val)
> break;
> default:
> ASSERT_UNREACHABLE();
> + break;
> }
>
> return 0;
> diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c
> index 699e8d536862..f719d9d767ab 100644
> --- a/xen/arch/arm/tee/optee.c
> +++ b/xen/arch/arm/tee/optee.c
> @@ -1206,6 +1206,7 @@ static void do_call_with_arg(struct optee_domain
> *ctx,
> default:
> /* Free any temporary shared buffers */
> free_shm_buffers(ctx, call->xen_arg);
> + break;
> }
>
> put_std_call(ctx, call);
> diff --git a/xen/arch/x86/mm/shadow/common.c
> b/xen/arch/x86/mm/shadow/common.c
> index 96986ee2553d..5834c265f76d 100644
> --- a/xen/arch/x86/mm/shadow/common.c
> +++ b/xen/arch/x86/mm/shadow/common.c
> @@ -1213,7 +1213,7 @@ void sh_destroy_shadow(struct domain *d, mfn_t
> smfn)
> #ifdef CONFIG_PV32
> case SH_type_l2h_64_shadow:
> ASSERT(is_pv_32bit_domain(d));
> - /* Fall through... */
> + fallthrough;
> #endif
> case SH_type_l2_64_shadow:
> SHADOW_INTERNAL_NAME(sh_destroy_l2_shadow, 4)(d, smfn);
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253