From: Denis Mukhin <dmukhin@ford.com>
{do_,}printk_ratelimit() are predicates. Make that pronounced by updating the
return value to boolean.
Not a functional change.
Signed-off-by: Denis Mukhin <dmukhin@ford.com>
---
Changes since v1:
- new patch
---
xen/drivers/char/console.c | 10 +++++-----
xen/include/xen/lib.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index af9ed38da553..c4c92e3efa39 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -1273,8 +1273,8 @@ void console_end_sync(void)
* This enforces a rate limit: not more than one kernel message
* every printk_ratelimit_ms (millisecs).
*/
-static int do_printk_ratelimit(unsigned int ratelimit_ms,
- unsigned int ratelimit_burst)
+static bool do_printk_ratelimit(unsigned int ratelimit_ms,
+ unsigned int ratelimit_burst)
{
static DEFINE_SPINLOCK(ratelimit_lock);
static unsigned long toks = 10 * 5 * 1000;
@@ -1313,11 +1313,11 @@ static int do_printk_ratelimit(unsigned int ratelimit_ms,
rspin_unlock(&console_lock);
}
local_irq_restore(flags);
- return 1;
+ return true;
}
missed++;
spin_unlock_irqrestore(&ratelimit_lock, flags);
- return 0;
+ return false;
}
/* Minimum time in ms between messages */
@@ -1326,7 +1326,7 @@ static const unsigned int printk_ratelimit_ms = 5 * 1000;
/* Number of messages we send before ratelimiting */
static const unsigned int printk_ratelimit_burst = 10;
-int printk_ratelimit(void)
+bool printk_ratelimit(void)
{
return do_printk_ratelimit(printk_ratelimit_ms, printk_ratelimit_burst);
}
diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h
index f516215ca8e4..e39fa9200c82 100644
--- a/xen/include/xen/lib.h
+++ b/xen/include/xen/lib.h
@@ -82,7 +82,7 @@ extern void guest_printk(const struct domain *d, const char *fmt, ...)
__attribute__ ((format (printf, 2, 3)));
extern void noreturn panic(const char *fmt, ...)
__attribute__ ((format (printf, 1, 2)));
-extern int printk_ratelimit(void);
+extern bool printk_ratelimit(void);
#define gprintk(lvl, fmt, args...) \
printk(XENLOG_GUEST lvl "%pv " fmt, current, ## args)
--
2.52.0