[PATCH 13/16] x86/cpu: Drop NOISY_CAPS

Andrew Cooper posted 16 patches 1 week, 4 days ago
[PATCH 13/16] x86/cpu: Drop NOISY_CAPS
Posted by Andrew Cooper 1 week, 4 days ago
These were plausibly useful for debugging when there were 4 words in
x86_capability[], but it's currently 22 words and growing.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Julian Vetter <julian.vetter@vates.tech>
CC: Teddy Astie <teddy.astie@vates.tech>

Even I can't read it in hex any more.
---
 xen/arch/x86/cpu/common.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
index 0249bb4bf2dc..7674cca1ba93 100644
--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -598,13 +598,6 @@ void identify_cpu(struct cpuinfo_x86 *c)
 		c->x86_capability[FEATURESET_m10Ah] = val >> 32;
 	}
 
-#ifdef NOISY_CAPS
-	printk(KERN_DEBUG "CPU: After vendor identify, caps:");
-	for (i = 0; i < NCAPINTS; i++)
-		printk(" %08x", c->x86_capability[i]);
-	printk("\n");
-#endif
-
 	/*
 	 * Vendor-specific initialization.  In this section we
 	 * canonicalize the feature flags, meaning if there are
@@ -641,13 +634,6 @@ void identify_cpu(struct cpuinfo_x86 *c)
 
 	xstate_init(c);
 
-#ifdef NOISY_CAPS
-	printk(KERN_DEBUG "CPU: After all inits, caps:");
-	for (i = 0; i < NCAPINTS; i++)
-		printk(" %08x", c->x86_capability[i]);
-	printk("\n");
-#endif
-
 	/*
 	 * If RDRAND is available, make an attempt to check that it actually
 	 * (still) works.
-- 
2.39.5


Re: [PATCH 13/16] x86/cpu: Drop NOISY_CAPS
Posted by Jan Beulich 1 week, 3 days ago
On 26.01.2026 18:53, Andrew Cooper wrote:
> These were plausibly useful for debugging when there were 4 words in
> x86_capability[], but it's currently 22 words and growing.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>