[PATCH] xen/gen_hypercall: Leave a breadcrumb in xen-hypercall-defs.h

Andrew Cooper posted 1 patch 4 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20260109131643.859509-1-andrew.cooper3@citrix.com
xen/scripts/gen_hypercall.awk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] xen/gen_hypercall: Leave a breadcrumb in xen-hypercall-defs.h
Posted by Andrew Cooper 4 weeks ago
When Cscope-ing through Xen, one occasionally finds themselves in
xen-hypercall-defs.h and needing to find the originating file.

This is substantially magic, and even reading the Makefile that produces
xen-hypercall-defs.h is of little help if you're not aware of of the %.i : %.c
pattern rule, and that the header is generated from a .c file in practice.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Anthony PERARD <anthony.perard@vates.tech>
CC: Michal Orzel <michal.orzel@amd.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Juergen Gross <jgross@suse.com>
---
 xen/scripts/gen_hypercall.awk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/scripts/gen_hypercall.awk b/xen/scripts/gen_hypercall.awk
index b544fe1c4df7..c137f8fc4e6d 100644
--- a/xen/scripts/gen_hypercall.awk
+++ b/xen/scripts/gen_hypercall.awk
@@ -4,7 +4,7 @@
 BEGIN {
     printf("#ifndef XEN_HYPERCALL_DEFS_H\n");
     printf("#define XEN_HYPERCALL_DEFS_H\n\n");
-    printf("/* Generated file, do not edit! */\n\n");
+    printf("/* Automatically generated from xen/include/hypercall-defs.c - do not edit! */\n\n");
     e = 0;
     n = 0;
     p = 0;
-- 
2.39.5


Re: [PATCH] xen/gen_hypercall: Leave a breadcrumb in xen-hypercall-defs.h
Posted by Jürgen Groß 4 weeks ago
On 09.01.26 14:16, Andrew Cooper wrote:
> When Cscope-ing through Xen, one occasionally finds themselves in
> xen-hypercall-defs.h and needing to find the originating file.
> 
> This is substantially magic, and even reading the Makefile that produces
> xen-hypercall-defs.h is of little help if you're not aware of of the %.i : %.c
> pattern rule, and that the header is generated from a .c file in practice.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen