[v5] Disable domctl-op via CONFIG_MGMT_HYPERCALLS

[PATCH v5 08/24] xen/mem_sharing: make memory sharing depend on MGMT_HYPERCALLS

Posted by Penny Zheng 1 month, 4 weeks ago

The enabling bit (d->arch.hvm.mem_sharing.enabled) for memory sharing could
only be enabled via domctl-op, so we shall make memory sharing feature
depend on MGMT_HYPERCALLS.

Signed-off-by: Penny Zheng <Penny.Zheng@amd.com>
---
v3 -> v4:
- new commit
---
 xen/arch/x86/hvm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/x86/hvm/Kconfig b/xen/arch/x86/hvm/Kconfig
index 25eb3e374f..df9bea65b0 100644
--- a/xen/arch/x86/hvm/Kconfig
+++ b/xen/arch/x86/hvm/Kconfig
@@ -79,5 +79,6 @@ config MEM_PAGING
 config MEM_SHARING
 	bool "Xen memory sharing support (UNSUPPORTED)" if UNSUPPORTED
 	depends on INTEL_VMX
+	depends on MGMT_HYPERCALLS
 
 endif
-- 
2.34.1

Re: [PATCH v5 08/24] xen/mem_sharing: make memory sharing depend on MGMT_HYPERCALLS

Posted by Jan Beulich 1 month, 4 weeks ago

On 12.12.2025 05:01, Penny Zheng wrote:
> The enabling bit (d->arch.hvm.mem_sharing.enabled) for memory sharing could
> only be enabled via domctl-op, so we shall make memory sharing feature
> depend on MGMT_HYPERCALLS.
> 
> Signed-off-by: Penny Zheng <Penny.Zheng@amd.com>

Tamas,

this is something that rather you should ack (or reject). (Penny, you would
have wanted to Cc Tamas here right away, no matter what F: entries in
./MAINTAINERS would say.)

Thanks, Jan

> --- a/xen/arch/x86/hvm/Kconfig
> +++ b/xen/arch/x86/hvm/Kconfig
> @@ -79,5 +79,6 @@ config MEM_PAGING
>  config MEM_SHARING
>  	bool "Xen memory sharing support (UNSUPPORTED)" if UNSUPPORTED
>  	depends on INTEL_VMX
> +	depends on MGMT_HYPERCALLS
>  
>  endif

Re: [PATCH v5 08/24] xen/mem_sharing: make memory sharing depend on MGMT_HYPERCALLS

Posted by Tamas K Lengyel 1 month, 4 weeks ago

On Fri, Dec 12, 2025 at 4:23 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 12.12.2025 05:01, Penny Zheng wrote:
> > The enabling bit (d->arch.hvm.mem_sharing.enabled) for memory sharing could
> > only be enabled via domctl-op, so we shall make memory sharing feature
> > depend on MGMT_HYPERCALLS.
> >
> > Signed-off-by: Penny Zheng <Penny.Zheng@amd.com>

Acked-by: Tamas K Lengyel <tamas@tklengyel.com>

>
> Tamas,
>
> this is something that rather you should ack (or reject). (Penny, you would
> have wanted to Cc Tamas here right away, no matter what F: entries in
> ./MAINTAINERS would say.)
>
> Thanks, Jan

Thanks, seems fine to me.

Tamas

RE: [PATCH v5 08/24] xen/mem_sharing: make memory sharing depend on MGMT_HYPERCALLS

Posted by Penny, Zheng 1 month, 3 weeks ago

[Public]

> -----Original Message-----
> From: Tamas K Lengyel <tamas@tklengyel.com>
> Sent: Saturday, December 13, 2025 8:21 AM
> To: Jan Beulich <jbeulich@suse.com>
> Cc: Penny, Zheng <penny.zheng@amd.com>; Huang, Ray
> <Ray.Huang@amd.com>; grygorii_strashko@epam.com; Andrew Cooper
> <andrew.cooper3@citrix.com>; Roger Pau Monné <roger.pau@citrix.com>; xen-
> devel@lists.xenproject.org
> Subject: Re: [PATCH v5 08/24] xen/mem_sharing: make memory sharing depend
> on MGMT_HYPERCALLS
>
> On Fri, Dec 12, 2025 at 4:23 AM Jan Beulich <jbeulich@suse.com> wrote:
> >
> > On 12.12.2025 05:01, Penny Zheng wrote:
> > > The enabling bit (d->arch.hvm.mem_sharing.enabled) for memory
> > > sharing could only be enabled via domctl-op, so we shall make memory
> > > sharing feature depend on MGMT_HYPERCALLS.
> > >
> > > Signed-off-by: Penny Zheng <Penny.Zheng@amd.com>
>
> Acked-by: Tamas K Lengyel <tamas@tklengyel.com>

Thx

>
> >
> > Tamas,
> >
> > this is something that rather you should ack (or reject). (Penny, you
> > would have wanted to Cc Tamas here right away, no matter what F:
> > entries in ./MAINTAINERS would say.)
> >
> > Thanks, Jan
>
> Thanks, seems fine to me.
>
> Tamas