[v3] xen/x86: move d->arch.physaddr_bitsize field handling to pv32

[PATCH v3 1/3] arm/ppc/riscv: drop unused domain_set_alloc_bitsize() macro

Posted by Grygorii Strashko 2 weeks, 1 day ago

From: Grygorii Strashko <grygorii_strashko@epam.com>

The domain_set_alloc_bitsize() is x86 PV32 specific and not used by other
arch or common code, so remove it.

Signed-off-by: Grygorii Strashko <grygorii_strashko@epam.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v3: no changes, added tag

 xen/arch/arm/include/asm/mm.h   | 1 -
 xen/arch/ppc/include/asm/mm.h   | 1 -
 xen/arch/riscv/include/asm/mm.h | 1 -
 3 files changed, 3 deletions(-)

diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
index f702f4a0d676..4c6cc64aa7ba 100644
--- a/xen/arch/arm/include/asm/mm.h
+++ b/xen/arch/arm/include/asm/mm.h
@@ -313,7 +313,6 @@ struct page_info *get_page_from_gva(struct vcpu *v, vaddr_t va,
 /* Arch-specific portion of memory_op hypercall. */
 long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-#define domain_set_alloc_bitsize(d) ((void)0)
 #define domain_clamp_alloc_bitsize(d, b) (b)
 
 unsigned long domain_get_maximum_gpfn(struct domain *d);
diff --git a/xen/arch/ppc/include/asm/mm.h b/xen/arch/ppc/include/asm/mm.h
index a33eeec43bd6..e478291fdf55 100644
--- a/xen/arch/ppc/include/asm/mm.h
+++ b/xen/arch/ppc/include/asm/mm.h
@@ -96,7 +96,6 @@ static inline struct page_info *virt_to_page(const void *v)
 /* TODO: implement */
 #define mfn_valid(mfn) ({ (void) (mfn); 0; })
 
-#define domain_set_alloc_bitsize(d) ((void)(d))
 #define domain_clamp_alloc_bitsize(d, b) (b)
 
 #define PFN_ORDER(pfn_) ((pfn_)->v.free.order)
diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h
index 9283616c0224..11e9f26bf0a5 100644
--- a/xen/arch/riscv/include/asm/mm.h
+++ b/xen/arch/riscv/include/asm/mm.h
@@ -292,7 +292,6 @@ static inline bool arch_mfns_in_directmap(unsigned long mfn, unsigned long nr)
 /* TODO: implement */
 #define mfn_valid(mfn) ({ (void)(mfn); 0; })
 
-#define domain_set_alloc_bitsize(d) ((void)(d))
 #define domain_clamp_alloc_bitsize(d, b) ((void)(d), (b))
 
 #define PFN_ORDER(pg) ((pg)->v.free.order)
-- 
2.34.1

Re: [PATCH v3 1/3] arm/ppc/riscv: drop unused domain_set_alloc_bitsize() macro

Posted by Orzel, Michal 5 days, 17 hours ago


On 28/11/2025 16:22, Grygorii Strashko wrote:
> From: Grygorii Strashko <grygorii_strashko@epam.com>
> 
> The domain_set_alloc_bitsize() is x86 PV32 specific and not used by other
> arch or common code, so remove it.
> 
> Signed-off-by: Grygorii Strashko <grygorii_strashko@epam.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Michal Orzel <michal.orzel@amd.com>

~Michal

Re: [PATCH v3 1/3] arm/ppc/riscv: drop unused domain_set_alloc_bitsize() macro

Posted by Oleksii Kurochko 5 days, 23 hours ago

On 11/28/25 4:22 PM, Grygorii Strashko wrote:
> From: Grygorii Strashko <grygorii_strashko@epam.com>
>
> The domain_set_alloc_bitsize() is x86 PV32 specific and not used by other
> arch or common code, so remove it.
>
> Signed-off-by: Grygorii Strashko <grygorii_strashko@epam.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> ---
> v3: no changes, added tag
>
>   xen/arch/arm/include/asm/mm.h   | 1 -
>   xen/arch/ppc/include/asm/mm.h   | 1 -
>   xen/arch/riscv/include/asm/mm.h | 1 -
>   3 files changed, 3 deletions(-)
>
> diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
> index f702f4a0d676..4c6cc64aa7ba 100644
> --- a/xen/arch/arm/include/asm/mm.h
> +++ b/xen/arch/arm/include/asm/mm.h
> @@ -313,7 +313,6 @@ struct page_info *get_page_from_gva(struct vcpu *v, vaddr_t va,
>   /* Arch-specific portion of memory_op hypercall. */
>   long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg);
>   
> -#define domain_set_alloc_bitsize(d) ((void)0)
>   #define domain_clamp_alloc_bitsize(d, b) (b)
>   
>   unsigned long domain_get_maximum_gpfn(struct domain *d);
> diff --git a/xen/arch/ppc/include/asm/mm.h b/xen/arch/ppc/include/asm/mm.h
> index a33eeec43bd6..e478291fdf55 100644
> --- a/xen/arch/ppc/include/asm/mm.h
> +++ b/xen/arch/ppc/include/asm/mm.h
> @@ -96,7 +96,6 @@ static inline struct page_info *virt_to_page(const void *v)
>   /* TODO: implement */
>   #define mfn_valid(mfn) ({ (void) (mfn); 0; })
>   
> -#define domain_set_alloc_bitsize(d) ((void)(d))
>   #define domain_clamp_alloc_bitsize(d, b) (b)
>   
>   #define PFN_ORDER(pfn_) ((pfn_)->v.free.order)
> diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h
> index 9283616c0224..11e9f26bf0a5 100644
> --- a/xen/arch/riscv/include/asm/mm.h
> +++ b/xen/arch/riscv/include/asm/mm.h
> @@ -292,7 +292,6 @@ static inline bool arch_mfns_in_directmap(unsigned long mfn, unsigned long nr)
>   /* TODO: implement */
>   #define mfn_valid(mfn) ({ (void)(mfn); 0; })
>   
> -#define domain_set_alloc_bitsize(d) ((void)(d))
>   #define domain_clamp_alloc_bitsize(d, b) ((void)(d), (b))
>   
>   #define PFN_ORDER(pg) ((pg)->v.free.order)

LGTM:
  Reviewed-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

Thanks.

~ Oleksii

Re: [PATCH v3 1/3] arm/ppc/riscv: drop unused domain_set_alloc_bitsize() macro

Posted by Luca Fancellu 2 weeks, 1 day ago

Hi Grygorii,

> On 28 Nov 2025, at 15:22, Grygorii Strashko <grygorii_strashko@epam.com> wrote:
> 
> From: Grygorii Strashko <grygorii_strashko@epam.com>
> 
> The domain_set_alloc_bitsize() is x86 PV32 specific and not used by other
> arch or common code, so remove it.
> 
> Signed-off-by: Grygorii Strashko <grygorii_strashko@epam.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> ---
> v3: no changes, added tag
> 
> xen/arch/arm/include/asm/mm.h   | 1 -

Looks good to me:

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com> #arm

Cheers,
Luca