A bit of cleanup around Error

[PATCH 0/5] A bit of cleanup around Error

Markus Armbruster posted 5 patches 3 weeks, 3 days ago

Download series mbox

Failed in applying to current master (apply log)

There is a newer version of this series

include/hw/loader.h         |  4 +++-
block/crypto.c              |  8 ++++----
hw/acpi/ghes.c              |  8 ++++----
hw/acpi/pcihp.c             |  4 +---
hw/arm/boot.c               |  6 +-----
hw/core/loader.c            |  8 ++++++--
hw/nvram/xlnx-bbram.c       | 18 ++++--------------
hw/ppc/spapr.c              | 16 ++++++++--------
hw/riscv/spike.c            | 10 +---------
hw/xen/xen-pvh-common.c     | 13 ++++++++++---
io/channel-websock.c        |  4 +---
io/task.c                   |  4 +---
migration/migration.c       |  6 ++----
nbd/client-connection.c     |  3 +--
nbd/common.c                |  6 +++---
tests/unit/test-smp-parse.c |  5 +----
16 files changed, 51 insertions(+), 72 deletions(-)

Expand all Fold all

[PATCH 0/5] A bit of cleanup around Error

Posted by Markus Armbruster 3 weeks, 3 days ago

Note: the last patch adds a drive-by FIXME.  I asked for advice on how
to fix it:

    Subject: Incorrect error handling in xen_enable_tpm()
    To: qemu-devel@nongnu.org
    Cc: Stefano Stabellini <sstabellini@kernel.org>, Anthony PERARD <anthony@xenproject.org>, Paul
     Durrant <paul@xen.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
     xen-devel@lists.xenproject.org, Vikram Garhwal <vikram.garhwal@amd.com> 
    Date: Fri, 14 Nov 2025 10:16:58 +0100
    Message-ID: <87jyzt0y9h.fsf@pond.sub.org>

No reply so far.

Markus Armbruster (5):
  hw/core/loader: Make load_elf_hdr() return bool, simplify caller
  hw/nvram/xlnx-bbram: More idiomatic and simpler error reporting
  nbd/client-connection: Replace error_propagate() by assignment
  error: error_free(NULL) is safe, drop unnecessary conditionals
  error: Consistently name Error * objects err, and not errp

 include/hw/loader.h         |  4 +++-
 block/crypto.c              |  8 ++++----
 hw/acpi/ghes.c              |  8 ++++----
 hw/acpi/pcihp.c             |  4 +---
 hw/arm/boot.c               |  6 +-----
 hw/core/loader.c            |  8 ++++++--
 hw/nvram/xlnx-bbram.c       | 18 ++++--------------
 hw/ppc/spapr.c              | 16 ++++++++--------
 hw/riscv/spike.c            | 10 +---------
 hw/xen/xen-pvh-common.c     | 13 ++++++++++---
 io/channel-websock.c        |  4 +---
 io/task.c                   |  4 +---
 migration/migration.c       |  6 ++----
 nbd/client-connection.c     |  3 +--
 nbd/common.c                |  6 +++---
 tests/unit/test-smp-parse.c |  5 +----
 16 files changed, 51 insertions(+), 72 deletions(-)

-- 
2.49.0