x86/ucode: Add extra rows to the entrysign model table

[PATCH] x86/ucode: Add extra rows to the entrysign model table

Posted by Andrew Cooper 1 month, 1 week ago

Link: https://git.kernel.org/tip/d23550efc6800841b4d1639784afaebdea946ae0
Fixes: ff8228ab4658 ("x86/ucode: Relax digest check when Entrysign is fixed in firmware")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
--
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/cpu/microcode/amd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c
index d72b9556f65f..550b8c1e57ec 100644
--- a/xen/arch/x86/cpu/microcode/amd.c
+++ b/xen/arch/x86/cpu/microcode/amd.c
@@ -655,10 +655,12 @@ void __init amd_check_entrysign(void)
     case 0x0aa001: fixed_rev = 0x17; break;
     case 0x0aa002: fixed_rev = 0x19; break;
     case 0x0b0021: fixed_rev = 0x47; break;
+    case 0x0b0081: fixed_rev = 0x12; break;
     case 0x0b1010: fixed_rev = 0x47; break;
     case 0x0b2040: fixed_rev = 0x32; break;
     case 0x0b4040: fixed_rev = 0x32; break;
     case 0x0b6000: fixed_rev = 0x32; break;
+    case 0x0b6080: fixed_rev = 0x32; break;
     case 0x0b7000: fixed_rev = 0x32; break;
     default:
         printk(XENLOG_WARNING
-- 
2.39.5

Re: [PATCH] x86/ucode: Add extra rows to the entrysign model table

Posted by Jan Beulich 1 month, 1 week ago

On 07.11.2025 14:47, Andrew Cooper wrote:
> Link: https://git.kernel.org/tip/d23550efc6800841b4d1639784afaebdea946ae0
> Fixes: ff8228ab4658 ("x86/ucode: Relax digest check when Entrysign is fixed in firmware")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

Pretty likely wants to go into 4.21? Cc-ing Oleksii, for him to judge.

Jan

Re: [PATCH] x86/ucode: Add extra rows to the entrysign model table

Posted by Andrew Cooper 1 month, 1 week ago

On 07/11/2025 2:30 pm, Jan Beulich wrote:
> On 07.11.2025 14:47, Andrew Cooper wrote:
>> Link: https://git.kernel.org/tip/d23550efc6800841b4d1639784afaebdea946ae0
>> Fixes: ff8228ab4658 ("x86/ucode: Relax digest check when Entrysign is fixed in firmware")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> Pretty likely wants to go into 4.21? Cc-ing Oleksii, for him to judge.

Yes, and backporting, but I've got more ucode bugfixes I'm working on.

One in particular was always broken, but exasperated by one of my recent
changes, but I'm not sure if the result is going to be comfortable for
4.21 at this juncture.

~Andrew

Re: [PATCH] x86/ucode: Add extra rows to the entrysign model table

Posted by Oleksii Kurochko 1 month ago

On 11/7/25 3:34 PM, Andrew Cooper wrote:
> On 07/11/2025 2:30 pm, Jan Beulich wrote:
>> On 07.11.2025 14:47, Andrew Cooper wrote:
>>> Link:https://git.kernel.org/tip/d23550efc6800841b4d1639784afaebdea946ae0
>>> Fixes: ff8228ab4658 ("x86/ucode: Relax digest check when Entrysign is fixed in firmware")
>>> Signed-off-by: Andrew Cooper<andrew.cooper3@citrix.com>
>> Acked-by: Jan Beulich<jbeulich@suse.com>
>>
>> Pretty likely wants to go into 4.21? Cc-ing Oleksii, for him to judge.
> Yes, and backporting, but I've got more ucode bugfixes I'm working on.
>
> One in particular was always broken, but exasperated by one of my recent
> changes, but I'm not sure if the result is going to be comfortable for
> 4.21 at this juncture.

I think it’s not a good idea to skip the SHA check, so it makes sense to
accept this patch:
  Release-Acked-By: Oleksii Kurochko<oleksii.kurochko@gmail.com>

Thanks.

~ Oleksii