1. Patchew
  2. Xen
  3. View series

[PATCH v2] MAINTAINERS: Add myself as an AMD SVM & IOMMU reviewer

Jason Andryuk posted 1 patch 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20251008201106.36204-1-jason.andryuk@amd.com
MAINTAINERS | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
[PATCH v2] MAINTAINERS: Add myself as an AMD SVM & IOMMU reviewer
Posted by Jason Andryuk 3 weeks ago 
Split out AMD SVM and AMD IOMMU, and add myself as a reviewer.  Jan,
Andrew and Roger are set as maintainers as they were for the X86 entry.

Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
---
v2:
Alphabetize entries
Add Roger's A-b
---
 MAINTAINERS | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 793561f63f..bc134ef9ec 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -220,6 +220,23 @@ F:	xen/drivers/acpi/
 F:	xen/include/acpi/
 F:	tools/libacpi/
 
+AMD IOMMU
+M:	Jan Beulich <jbeulich@suse.com>
+M:	Andrew Cooper <andrew.cooper3@citrix.com>
+M:	Roger Pau Monné <roger.pau@citrix.com>
+R:	Jason Andryuk <jason.andryuk@amd.com>
+S:	Supported
+F:	xen/drivers/passthrough/amd/
+
+AMD SVM
+M:	Jan Beulich <jbeulich@suse.com>
+M:	Andrew Cooper <andrew.cooper3@citrix.com>
+M:	Roger Pau Monné <roger.pau@citrix.com>
+R:	Jason Andryuk <jason.andryuk@amd.com>
+S:	Supported
+F:	xen/arch/x86/hvm/svm/
+F:	xen/arch/x86/cpu/vpmu_amd.c
+
 ARGO
 M:	Christopher Clark <christopher.w.clark@gmail.com>
 R:	Daniel P. Smith <dpsmith@apertussolutions.com>
@@ -601,7 +618,8 @@ M:	Roger Pau Monné <roger.pau@citrix.com>
 S:	Supported
 L:	xen-devel@lists.xenproject.org
 F:	xen/arch/x86/
-F:	xen/drivers/passthrough/amd/
+X:	xen/arch/x86/hvm/svm/
+X:	xen/arch/x86/cpu/vpmu_amd.c
 F:	xen/drivers/passthrough/vtd/
 F:	xen/include/public/arch-x86/
 F:	xen/include/xen/lib/x86/
-- 
2.51.0
Re: [PATCH v2] MAINTAINERS: Add myself as an AMD SVM & IOMMU reviewer
Posted by Jan Beulich 3 weeks ago 
On 08.10.2025 22:11, Jason Andryuk wrote:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -220,6 +220,23 @@ F:	xen/drivers/acpi/
>  F:	xen/include/acpi/
>  F:	tools/libacpi/
>  
> +AMD IOMMU
> +M:	Jan Beulich <jbeulich@suse.com>
> +M:	Andrew Cooper <andrew.cooper3@citrix.com>
> +M:	Roger Pau Monné <roger.pau@citrix.com>
> +R:	Jason Andryuk <jason.andryuk@amd.com>
> +S:	Supported
> +F:	xen/drivers/passthrough/amd/
> +
> +AMD SVM
> +M:	Jan Beulich <jbeulich@suse.com>
> +M:	Andrew Cooper <andrew.cooper3@citrix.com>
> +M:	Roger Pau Monné <roger.pau@citrix.com>
> +R:	Jason Andryuk <jason.andryuk@amd.com>
> +S:	Supported
> +F:	xen/arch/x86/hvm/svm/
> +F:	xen/arch/x86/cpu/vpmu_amd.c

What about xen/arch/x86/include/asm/hvm/svm/ ? It didn't need specific
mentioning on the X86 entry, but it would now. Also F: entries generally
want sorting alphabetically as well.

> @@ -601,7 +618,8 @@ M:	Roger Pau Monné <roger.pau@citrix.com>
>  S:	Supported
>  L:	xen-devel@lists.xenproject.org
>  F:	xen/arch/x86/
> -F:	xen/drivers/passthrough/amd/
> +X:	xen/arch/x86/hvm/svm/
> +X:	xen/arch/x86/cpu/vpmu_amd.c

Didn't the v1 discussion result in there being no need for these X:
entries?

As long as there's agreement, I'd be happy to make adjustments while
committing. Oleksii - I take it that ./MAINTAINERS changes can still go
in pretty freely?

Jan
Re: [PATCH v2] MAINTAINERS: Add myself as an AMD SVM & IOMMU reviewer
Posted by Oleksii Kurochko 3 weeks ago 
On 10/9/25 2:36 PM, Jan Beulich wrote:
> On 08.10.2025 22:11, Jason Andryuk wrote:
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -220,6 +220,23 @@ F:	xen/drivers/acpi/
>>   F:	xen/include/acpi/
>>   F:	tools/libacpi/
>>   
>> +AMD IOMMU
>> +M:	Jan Beulich<jbeulich@suse.com>
>> +M:	Andrew Cooper<andrew.cooper3@citrix.com>
>> +M:	Roger Pau Monné<roger.pau@citrix.com>
>> +R:	Jason Andryuk<jason.andryuk@amd.com>
>> +S:	Supported
>> +F:	xen/drivers/passthrough/amd/
>> +
>> +AMD SVM
>> +M:	Jan Beulich<jbeulich@suse.com>
>> +M:	Andrew Cooper<andrew.cooper3@citrix.com>
>> +M:	Roger Pau Monné<roger.pau@citrix.com>
>> +R:	Jason Andryuk<jason.andryuk@amd.com>
>> +S:	Supported
>> +F:	xen/arch/x86/hvm/svm/
>> +F:	xen/arch/x86/cpu/vpmu_amd.c
> What about xen/arch/x86/include/asm/hvm/svm/ ? It didn't need specific
> mentioning on the X86 entry, but it would now. Also F: entries generally
> want sorting alphabetically as well.
>
>> @@ -601,7 +618,8 @@ M:	Roger Pau Monné<roger.pau@citrix.com>
>>   S:	Supported
>>   L:	xen-devel@lists.xenproject.org
>>   F:	xen/arch/x86/
>> -F:	xen/drivers/passthrough/amd/
>> +X:	xen/arch/x86/hvm/svm/
>> +X:	xen/arch/x86/cpu/vpmu_amd.c
> Didn't the v1 discussion result in there being no need for these X:
> entries?
>
> As long as there's agreement, I'd be happy to make adjustments while
> committing. Oleksii - I take it that ./MAINTAINERS changes can still go
> in pretty freely?

Yes, you are right. Feel free to commit such changes without R-Acked-by.

~ Oleksii
Re: [PATCH v2] MAINTAINERS: Add myself as an AMD SVM & IOMMU reviewer
Posted by Jason Andryuk 3 weeks ago 
On 2025-10-09 08:36, Jan Beulich wrote:
> On 08.10.2025 22:11, Jason Andryuk wrote:
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -220,6 +220,23 @@ F:	xen/drivers/acpi/
>>   F:	xen/include/acpi/
>>   F:	tools/libacpi/
>>   
>> +AMD IOMMU
>> +M:	Jan Beulich <jbeulich@suse.com>
>> +M:	Andrew Cooper <andrew.cooper3@citrix.com>
>> +M:	Roger Pau Monné <roger.pau@citrix.com>
>> +R:	Jason Andryuk <jason.andryuk@amd.com>
>> +S:	Supported
>> +F:	xen/drivers/passthrough/amd/
>> +
>> +AMD SVM
>> +M:	Jan Beulich <jbeulich@suse.com>
>> +M:	Andrew Cooper <andrew.cooper3@citrix.com>
>> +M:	Roger Pau Monné <roger.pau@citrix.com>
>> +R:	Jason Andryuk <jason.andryuk@amd.com>
>> +S:	Supported
>> +F:	xen/arch/x86/hvm/svm/
>> +F:	xen/arch/x86/cpu/vpmu_amd.c
> 
> What about xen/arch/x86/include/asm/hvm/svm/ ? It didn't need specific
> mentioning on the X86 entry, but it would now. Also F: entries generally
> want sorting alphabetically as well.

Yes, that all sounds good.  I based this on a revert of 
8395f275ebd11b4cacb12da09911e7918ccc7518 and alphabetization was 
incorrect there.  Sorry about that.

>> @@ -601,7 +618,8 @@ M:	Roger Pau Monné <roger.pau@citrix.com>
>>   S:	Supported
>>   L:	xen-devel@lists.xenproject.org
>>   F:	xen/arch/x86/
>> -F:	xen/drivers/passthrough/amd/
>> +X:	xen/arch/x86/hvm/svm/
>> +X:	xen/arch/x86/cpu/vpmu_amd.c
> 
> Didn't the v1 discussion result in there being no need for these X:
> entries?

I thought Anthony said they should be split out for proper nesting:

 >The exclusion is likely unnecessary, and ./get_maintainer.pl will just
 >get the information (email, ...) from every sections that a file match.
 >But the duplication is necessary due to the "The meaning of nesting"
 >described in the MAINTAINERS file.

I took the second sentence to mean they should remain.

> As long as there's agreement, I'd be happy to make adjustments while
> committing. Oleksii - I take it that ./MAINTAINERS changes can still go
> in pretty freely?

Thanks,
Jason
Re: [PATCH v2] MAINTAINERS: Add myself as an AMD SVM & IOMMU reviewer
Posted by Jan Beulich 3 weeks ago 
On 09.10.2025 10:19, Jason Andryuk wrote:
> On 2025-10-09 08:36, Jan Beulich wrote:
>> On 08.10.2025 22:11, Jason Andryuk wrote:
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -220,6 +220,23 @@ F:	xen/drivers/acpi/
>>>   F:	xen/include/acpi/
>>>   F:	tools/libacpi/
>>>   
>>> +AMD IOMMU
>>> +M:	Jan Beulich <jbeulich@suse.com>
>>> +M:	Andrew Cooper <andrew.cooper3@citrix.com>
>>> +M:	Roger Pau Monné <roger.pau@citrix.com>
>>> +R:	Jason Andryuk <jason.andryuk@amd.com>
>>> +S:	Supported
>>> +F:	xen/drivers/passthrough/amd/
>>> +
>>> +AMD SVM
>>> +M:	Jan Beulich <jbeulich@suse.com>
>>> +M:	Andrew Cooper <andrew.cooper3@citrix.com>
>>> +M:	Roger Pau Monné <roger.pau@citrix.com>
>>> +R:	Jason Andryuk <jason.andryuk@amd.com>
>>> +S:	Supported
>>> +F:	xen/arch/x86/hvm/svm/
>>> +F:	xen/arch/x86/cpu/vpmu_amd.c
>>
>> What about xen/arch/x86/include/asm/hvm/svm/ ? It didn't need specific
>> mentioning on the X86 entry, but it would now. Also F: entries generally
>> want sorting alphabetically as well.
> 
> Yes, that all sounds good.  I based this on a revert of 
> 8395f275ebd11b4cacb12da09911e7918ccc7518 and alphabetization was 
> incorrect there.  Sorry about that.
> 
>>> @@ -601,7 +618,8 @@ M:	Roger Pau Monné <roger.pau@citrix.com>
>>>   S:	Supported
>>>   L:	xen-devel@lists.xenproject.org
>>>   F:	xen/arch/x86/
>>> -F:	xen/drivers/passthrough/amd/
>>> +X:	xen/arch/x86/hvm/svm/
>>> +X:	xen/arch/x86/cpu/vpmu_amd.c
>>
>> Didn't the v1 discussion result in there being no need for these X:
>> entries?
> 
> I thought Anthony said they should be split out for proper nesting:
> 
>  >The exclusion is likely unnecessary, and ./get_maintainer.pl will just
>  >get the information (email, ...) from every sections that a file match.
>  >But the duplication is necessary due to the "The meaning of nesting"
>  >described in the MAINTAINERS file.
> 
> I took the second sentence to mean they should remain.

But the 2nd sentence was about duplication (i.e. splitting), not
exclusion.

Jan

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.