Add json-c package for libxl usage.  At the same time drop YAJL.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Would be nice to have for 4.21, so that we test with json-c instead of
YAJL.  I plan to switch the FreeBSD Xen port use json-c for 4.21.

All seems fine:

https://cirrus-ci.com/build/5366905441091584
---
 .cirrus.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.cirrus.yml b/.cirrus.yml
index 7df7ff552222..0de1012d8c60 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -50,7 +50,7 @@ task:
 
   install_script: pkg install -y seabios gmake ninja bash
                                  pkgconf bison perl5
-                                 yajl lzo2 pixman argp-standalone
+                                 json-c lzo2 pixman argp-standalone
                                  libxml2 glib git python3 libinotify
 
   configure_script:
-- 
2.51.0

On 10/7/25 6:13 PM, Roger Pau Monne wrote:
> Add json-c package for libxl usage.  At the same time drop YAJL.
>
> Signed-off-by: Roger Pau Monné<roger.pau@citrix.com>
> ---
> Would be nice to have for 4.21, so that we test with json-c instead of
> YAJL.  I plan to switch the FreeBSD Xen port use json-c for 4.21.

Release-Acked-by: Oleksii Kurochko<oleksii.kurochko@gmail.com>

Thanks.

~ Oleksii

>
> All seems fine:
>
> https://cirrus-ci.com/build/5366905441091584
> ---
>   .cirrus.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.cirrus.yml b/.cirrus.yml
> index 7df7ff552222..0de1012d8c60 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -50,7 +50,7 @@ task:
>   
>     install_script: pkg install -y seabios gmake ninja bash
>                                    pkgconf bison perl5
> -                                 yajl lzo2 pixman argp-standalone
> +                                 json-c lzo2 pixman argp-standalone
>                                    libxml2 glib git python3 libinotify
>   
>     configure_script:

On 07/10/2025 5:13 pm, Roger Pau Monne wrote:
> Add json-c package for libxl usage.  At the same time drop YAJL.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Would be nice to have for 4.21, so that we test with json-c instead of
> YAJL.  I plan to switch the FreeBSD Xen port use json-c for 4.21.
>
> All seems fine:
>
> https://cirrus-ci.com/build/5366905441091584
> ---
>  .cirrus.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.cirrus.yml b/.cirrus.yml
> index 7df7ff552222..0de1012d8c60 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -50,7 +50,7 @@ task:
>  
>    install_script: pkg install -y seabios gmake ninja bash
>                                   pkgconf bison perl5
> -                                 yajl lzo2 pixman argp-standalone
> +                                 json-c lzo2 pixman argp-standalone
>                                   libxml2 glib git python3 libinotify
>  
>    configure_script:


Comparing before and after, we've got:

- yajl: 2.1.0

- Number of packages to be installed: 27
+ Number of packages to be installed: 26

So, json-c seems to be in the base image, but even that points to it
being a more popular library and the right way for Xen to be moving.

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

On Tue, Oct 07, 2025 at 06:06:45PM +0100, Andrew Cooper wrote:
> On 07/10/2025 5:13 pm, Roger Pau Monne wrote:
> > Add json-c package for libxl usage.  At the same time drop YAJL.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > Would be nice to have for 4.21, so that we test with json-c instead of
> > YAJL.  I plan to switch the FreeBSD Xen port use json-c for 4.21.
> >
> > All seems fine:
> >
> > https://cirrus-ci.com/build/5366905441091584
> > ---
> >  .cirrus.yml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.cirrus.yml b/.cirrus.yml
> > index 7df7ff552222..0de1012d8c60 100644
> > --- a/.cirrus.yml
> > +++ b/.cirrus.yml
> > @@ -50,7 +50,7 @@ task:
> >  
> >    install_script: pkg install -y seabios gmake ninja bash
> >                                   pkgconf bison perl5
> > -                                 yajl lzo2 pixman argp-standalone
> > +                                 json-c lzo2 pixman argp-standalone
> >                                   libxml2 glib git python3 libinotify
> >  
> >    configure_script:
> 
> 
> Comparing before and after, we've got:
> 
> - yajl: 2.1.0
> 
> - Number of packages to be installed: 27
> + Number of packages to be installed: 26
> 
> So, json-c seems to be in the base image, but even that points to it
> being a more popular library and the right way for Xen to be moving.

My bet (I haven't checked) is that it's also used by the cloud init
scripts that are packed in gcloud images used by Cirrus-CI.  It's not
part of the base (non-cloud) images AFAICT.

> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks, Roger.