Be explicit about root in scripts/alpine-rootfs.sh

[PATCH TEST-ARTEFACTS] Be explicit about root in scripts/alpine-rootfs.sh

Posted by Andrew Cooper 4 days, 10 hours ago

The container is running as root, but be explicit anyway.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Anthony PERARD <anthony.perard@vates.tech>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
 scripts/alpine-rootfs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/alpine-rootfs.sh b/scripts/alpine-rootfs.sh
index c999b89dbcd8..6fa1d56775bc 100755
--- a/scripts/alpine-rootfs.sh
+++ b/scripts/alpine-rootfs.sh
@@ -84,7 +84,7 @@ cd /
     PATHS="bin etc home init lib mnt opt root sbin srv usr var"
     find $PATHS -print0
     echo -ne "dev\0proc\0run\0sys\0"
-} | cpio -0 -H newc -o | gzip > "${COPYDIR}/rootfs.cpio.gz"
+} | cpio -0 -R 0:0 -H newc -o | gzip > "${COPYDIR}/rootfs.cpio.gz"
 
 # Print the contents for the build log
 zcat "${COPYDIR}/rootfs.cpio.gz" | cpio -tv

base-commit: d7434697deec41ddf31a2f3d189dee75d4d2486f
-- 
2.39.5

Re: [PATCH TEST-ARTEFACTS] Be explicit about root in scripts/alpine-rootfs.sh

Posted by dmukhin@xen.org 4 days, 8 hours ago

On Tue, Sep 09, 2025 at 06:01:11PM +0100, Andrew Cooper wrote:
> The container is running as root, but be explicit anyway.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Denis Mukhin <dmukhin@ford.com> 

> ---
> CC: Anthony PERARD <anthony.perard@vates.tech>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> ---
>  scripts/alpine-rootfs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/alpine-rootfs.sh b/scripts/alpine-rootfs.sh
> index c999b89dbcd8..6fa1d56775bc 100755
> --- a/scripts/alpine-rootfs.sh
> +++ b/scripts/alpine-rootfs.sh
> @@ -84,7 +84,7 @@ cd /
>      PATHS="bin etc home init lib mnt opt root sbin srv usr var"
>      find $PATHS -print0
>      echo -ne "dev\0proc\0run\0sys\0"
> -} | cpio -0 -H newc -o | gzip > "${COPYDIR}/rootfs.cpio.gz"
> +} | cpio -0 -R 0:0 -H newc -o | gzip > "${COPYDIR}/rootfs.cpio.gz"
>  
>  # Print the contents for the build log
>  zcat "${COPYDIR}/rootfs.cpio.gz" | cpio -tv
> 
> base-commit: d7434697deec41ddf31a2f3d189dee75d4d2486f
> -- 
> 2.39.5
> 
>

Re: [PATCH TEST-ARTEFACTS] Be explicit about root in scripts/alpine-rootfs.sh

Posted by Stefano Stabellini 4 days, 3 hours ago

On Tue, 9 Sep 2025, dmukhin@xen.org wrote:
> On Tue, Sep 09, 2025 at 06:01:11PM +0100, Andrew Cooper wrote:
> > The container is running as root, but be explicit anyway.
> > 
> > No functional change.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> Reviewed-by: Denis Mukhin <dmukhin@ford.com> 

Acked-by: Stefano Stabellini <sstabellini@kernel.org>