x86/boot: Remove unused symbols from linker script

[PATCH] x86/boot: Remove unused symbols from linker script

Frediano Ziglio posted 1 patch 2 months, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20250812151923.96832-1-frediano.ziglio@cloud.com

xen/arch/x86/boot/build32.lds.S | 2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[PATCH] x86/boot: Remove unused symbols from linker script

Posted by Frediano Ziglio 2 months, 2 weeks ago

The symbols declared with DECLARE_IMPORT are meant to be
used by the 32 bit code.
The __base_relocs_{start,end} symbols were not used by the
code.
No functional changes.

Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
---
 xen/arch/x86/boot/build32.lds.S | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/arch/x86/boot/build32.lds.S b/xen/arch/x86/boot/build32.lds.S
index 1e59732edd..e4f7c7fc2f 100644
--- a/xen/arch/x86/boot/build32.lds.S
+++ b/xen/arch/x86/boot/build32.lds.S
@@ -43,8 +43,6 @@ SECTIONS
          * Attention should be paid to pointers taking care of possible later
          * relocation.
          */
-        DECLARE_IMPORT(__base_relocs_start);
-        DECLARE_IMPORT(__base_relocs_end);
         DECLARE_IMPORT(__trampoline_rel_start);
         DECLARE_IMPORT(__trampoline_rel_stop);
         DECLARE_IMPORT(__trampoline_seg_start);
-- 
2.43.0

Re: [PATCH] x86/boot: Remove unused symbols from linker script

Posted by Andrew Cooper 2 months, 2 weeks ago

On 12/08/2025 4:19 pm, Frediano Ziglio wrote:
> The symbols declared with DECLARE_IMPORT are meant to be
> used by the 32 bit code.
> The __base_relocs_{start,end} symbols were not used by the
> code.
> No functional changes.
>
> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>

Reported-by: Jan

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Can be fixed on commit.