[XEN][PATCH] xen/arm: remove unused dump_p2m_lookup()

Grygorii Strashko posted 1 patch 3 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20250718101535.3109001-1-grygorii._5Fstrashko@epam.com
xen/arch/arm/include/asm/page.h |  2 --
xen/arch/arm/mmu/p2m.c          | 13 -------------
2 files changed, 15 deletions(-)
[XEN][PATCH] xen/arm: remove unused dump_p2m_lookup()
Posted by Grygorii Strashko 3 months, 2 weeks ago
From: Grygorii Strashko <grygorii_strashko@epam.com>

The dump_p2m_lookup() is not used, so remove it.

Signed-off-by: Grygorii Strashko <grygorii_strashko@epam.com>
---
 xen/arch/arm/include/asm/page.h |  2 --
 xen/arch/arm/mmu/p2m.c          | 13 -------------
 2 files changed, 15 deletions(-)

diff --git a/xen/arch/arm/include/asm/page.h b/xen/arch/arm/include/asm/page.h
index 27bc96b9f401..623fa09e1932 100644
--- a/xen/arch/arm/include/asm/page.h
+++ b/xen/arch/arm/include/asm/page.h
@@ -289,8 +289,6 @@ void flush_page_to_ram(unsigned long mfn, bool sync_icache);
 
 /* Print a walk of the hypervisor's page tables for a virtual addr. */
 extern void dump_hyp_walk(vaddr_t addr);
-/* Print a walk of the p2m for a domain for a physical address. */
-extern void dump_p2m_lookup(struct domain *d, paddr_t addr);
 
 static inline uint64_t va_to_par(vaddr_t va)
 {
diff --git a/xen/arch/arm/mmu/p2m.c b/xen/arch/arm/mmu/p2m.c
index 67296dabb587..51abf3504fcf 100644
--- a/xen/arch/arm/mmu/p2m.c
+++ b/xen/arch/arm/mmu/p2m.c
@@ -178,19 +178,6 @@ void p2m_dump_info(struct domain *d)
     p2m_read_unlock(p2m);
 }
 
-void dump_p2m_lookup(struct domain *d, paddr_t addr)
-{
-    struct p2m_domain *p2m = p2m_get_hostp2m(d);
-
-    printk("dom%d IPA 0x%"PRIpaddr"\n", d->domain_id, addr);
-
-    printk("P2M @ %p mfn:%#"PRI_mfn"\n",
-           p2m->root, mfn_x(page_to_mfn(p2m->root)));
-
-    dump_pt_walk(page_to_maddr(p2m->root), addr,
-                 P2M_ROOT_LEVEL, P2M_ROOT_PAGES);
-}
-
 /*
  * p2m_save_state and p2m_restore_state work in pair to workaround
  * ARM64_WORKAROUND_AT_SPECULATE. p2m_save_state will set-up VTTBR to
-- 
2.34.1
Re: [XEN][PATCH] xen/arm: remove unused dump_p2m_lookup()
Posted by Orzel, Michal 3 months, 1 week ago

On 18/07/2025 12:15, Grygorii Strashko wrote:
> From: Grygorii Strashko <grygorii_strashko@epam.com>
> 
> The dump_p2m_lookup() is not used, so remove it.
> 
> Signed-off-by: Grygorii Strashko <grygorii_strashko@epam.com>
Acked-by: Michal Orzel <michal.orzel@amd.com>

~Michal
Re: [XEN][PATCH] xen/arm: remove unused dump_p2m_lookup()
Posted by Hari Limaye 3 months, 1 week ago
Hi Grygorii,

> On Fri, Jul 18, 2025 at 10:15:36AM +0000, Grygorii Strashko wrote:
> From: Grygorii Strashko <grygorii_strashko@epam.com>
> 
> The dump_p2m_lookup() is not used, so remove it.

NIT: I think this would read better as 'The function dump_p2m_lookup()...'

Otherwise LGTM!

Reviewed-by: Hari Limaye <hari.limaye@arm.com>

Cheers,
Hari