[ImageBuilder][PATCH] Fix DOM0_CMD options for early console

Michal Orzel posted 1 patch 3 months, 2 weeks ago
Failed in applying to current master (apply log)
scripts/uboot-script-gen | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[ImageBuilder][PATCH] Fix DOM0_CMD options for early console
Posted by Michal Orzel 3 months, 2 weeks ago
Fix incorrect earlycon option that should be xenboot instead of xen.
Refer:
https://elixir.bootlin.com/linux/v6.15.6/source/drivers/tty/hvc/hvc_xen.c#L772

Fix incorrect earlyprintk option. On Arm32 (Arm64 does not have
earlyprintk), it should be just earlyprintk which will enable compiled
in (if at all) debug printk code.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
 scripts/uboot-script-gen | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
index dfa154efaa1b..d451dc22e843 100755
--- a/scripts/uboot-script-gen
+++ b/scripts/uboot-script-gen
@@ -903,7 +903,7 @@ function xen_config()
 
     if [ -z "$DOM0_CMD" ]
     then
-        DOM0_CMD="console=hvc0 earlycon=xen earlyprintk=xen clk_ignore_unused"
+        DOM0_CMD="console=hvc0 earlycon=xenboot earlyprintk clk_ignore_unused"
     fi
     if [[ ! $DOM0_CMD =~ root= ]]
     then
-- 
2.43.0
Re: [ImageBuilder][PATCH] Fix DOM0_CMD options for early console
Posted by Luca Fancellu 3 months, 2 weeks ago
Hi Michal,

> On 16 Jul 2025, at 10:26, Michal Orzel <michal.orzel@amd.com> wrote:
> 
> Fix incorrect earlycon option that should be xenboot instead of xen.
> Refer:
> https://elixir.bootlin.com/linux/v6.15.6/source/drivers/tty/hvc/hvc_xen.c#L772
> 
> Fix incorrect earlyprintk option. On Arm32 (Arm64 does not have
> earlyprintk), it should be just earlyprintk which will enable compiled
> in (if at all) debug printk code.
> 
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> ---

I’m not an ImageBuilder expert, but the change looks sensible to me:

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>


Re: [ImageBuilder][PATCH] Fix DOM0_CMD options for early console
Posted by Stefano Stabellini 3 months, 2 weeks ago
On Wed, 16 Jul 2025, Luca Fancellu wrote:
> Hi Michal,
> 
> > On 16 Jul 2025, at 10:26, Michal Orzel <michal.orzel@amd.com> wrote:
> > 
> > Fix incorrect earlycon option that should be xenboot instead of xen.
> > Refer:
> > https://elixir.bootlin.com/linux/v6.15.6/source/drivers/tty/hvc/hvc_xen.c#L772
> > 
> > Fix incorrect earlyprintk option. On Arm32 (Arm64 does not have
> > earlyprintk), it should be just earlyprintk which will enable compiled
> > in (if at all) debug printk code.
> > 
> > Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> > ---
> 
> I’m not an ImageBuilder expert, but the change looks sensible to me:
> 
> Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>