xen/efi: Do not undefine not defined macro

[PATCH v2] xen/efi: Do not undefine not defined macro

Posted by Frediano Ziglio 4 months, 1 week ago

The "buffer" macro is not defined.

Fixes: 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")
Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
Changes since v1:
- fixed commit message;
- added Acked-by.
---
 xen/common/efi/boot.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 1a181ba933..c5625ccecf 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -556,7 +556,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
     else
         *leaf = buffer;
 #undef BUFFERSIZE
-#undef buffer
 
     return dir_handle;
 }
-- 
2.43.0

Re: [PATCH v2] xen/efi: Do not undefine not defined macro

Posted by Andrew Cooper 4 months, 1 week ago

On 24/06/2025 12:45 pm, Frediano Ziglio wrote:
> The "buffer" macro is not defined.
>
> Fixes: 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")
> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

While correct, the grammar isn't great.  I'd suggest "Drop stale #undef
buffer" for the subject, and "The "buffer" macro was removed when
keyhandler_scratch was removed."

Can fix on commit.

~Andrew

Re: [PATCH v2] xen/efi: Do not undefine not defined macro

Posted by Frediano Ziglio 4 months, 1 week ago

On Tue, Jun 24, 2025 at 12:57 PM Andrew Cooper
<andrew.cooper3@citrix.com> wrote:
>
> On 24/06/2025 12:45 pm, Frediano Ziglio wrote:
> > The "buffer" macro is not defined.
> >
> > Fixes: 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")
> > Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> > Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
>
> While correct, the grammar isn't great.  I'd suggest "Drop stale #undef
> buffer" for the subject, and "The "buffer" macro was removed when
> keyhandler_scratch was removed."
>

Fine for me.
Not sure about the acknowledgement.

> Can fix on commit.
>
> ~Andrew

Frediano

Re: [PATCH v2] xen/efi: Do not undefine not defined macro

Posted by Marek Marczykowski-Górecki 4 months, 1 week ago

On Tue, Jun 24, 2025 at 12:59:18PM +0100, Frediano Ziglio wrote:
> On Tue, Jun 24, 2025 at 12:57 PM Andrew Cooper
> <andrew.cooper3@citrix.com> wrote:
> >
> > On 24/06/2025 12:45 pm, Frediano Ziglio wrote:
> > > The "buffer" macro is not defined.
> > >
> > > Fixes: 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")
> > > Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> > > Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> >
> > While correct, the grammar isn't great.  I'd suggest "Drop stale #undef
> > buffer" for the subject, and "The "buffer" macro was removed when
> > keyhandler_scratch was removed."
> >
> 
> Fine for me.

Fine with me too.

> Not sure about the acknowledgement.
> 
> > Can fix on commit.
> >
> > ~Andrew
> 
> Frediano

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab