[v1] xen/common: Guard freeze/thaw_domains functions with CONFIG_SYSTEM_SUSPEND

[PATCH] xen/common: Guard freeze/thaw_domains functions with CONFIG_SYSTEM_SUSPEND

Mykola Kvach posted 1 patch 4 months, 1 week ago

Diff against v2
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20250624065601.197492-1-xakep.amatop@gmail.com

There is a newer version of this series

xen/common/domain.c | 4 ++++
1 file changed, 4 insertions(+)

Expand all Fold all

[PATCH] xen/common: Guard freeze/thaw_domains functions with CONFIG_SYSTEM_SUSPEND

Posted by Mykola Kvach 4 months, 1 week ago

From: Mykola Kvach <mykola_kvach@epam.com>

This patch adds CONFIG_SYSTEM_SUSPEND guards around freeze_domains
and thaw_domains functions.

This ensures they are only compiled into the hypervisor when the system
suspend functionality is enabled, aligning their inclusion with their
specific use case.

Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>
---
 xen/common/domain.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/common/domain.c b/xen/common/domain.c
index 8c8f70347a..303c338ef2 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -2411,6 +2411,8 @@ domid_t get_initial_domain_id(void)
     return 0;
 }
 
+#ifdef CONFIG_SYSTEM_SUSPEND
+
 void freeze_domains(void)
 {
     struct domain *d;
@@ -2436,6 +2438,8 @@ void thaw_domains(void)
     rcu_read_unlock(&domlist_read_lock);
 }
 
+#endif /* CONFIG_SYSTEM_SUSPEND */
+
 /*
  * Local variables:
  * mode: C
-- 
2.48.1

Re: [PATCH] xen/common: Guard freeze/thaw_domains functions with CONFIG_SYSTEM_SUSPEND

Posted by Jan Beulich 4 months, 1 week ago

On 24.06.2025 08:56, Mykola Kvach wrote:
> From: Mykola Kvach <mykola_kvach@epam.com>
> 
> This patch adds CONFIG_SYSTEM_SUSPEND guards around freeze_domains
> and thaw_domains functions.
> 
> This ensures they are only compiled into the hypervisor when the system
> suspend functionality is enabled, aligning their inclusion with their
> specific use case.

This addresses two Misra Rule 2.1 violations.

> Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

With the addition (happy to add while committing)
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan