The "buffer" macro is not defined.
It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff
(cfr "xen/keyhandler: Drop keyhandler_scratch").

Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
---
 xen/common/efi/boot.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index ded7cc129d..1a9b4e7dae 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
     else
         *leaf = buffer;
 #undef BUFFERSIZE
-#undef buffer
 
     return dir_handle;
 }
-- 
2.43.0

On Tue, Jun 24, 2025 at 7:36 AM Frediano Ziglio
<frediano.ziglio@cloud.com> wrote:
>

Typo on title "Do not undefined not defined macro" -> "Do not undefine
not defined macro"

> The "buffer" macro is not defined.
> It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff
> (cfr "xen/keyhandler: Drop keyhandler_scratch").
>
> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> ---
>  xen/common/efi/boot.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> index ded7cc129d..1a9b4e7dae 100644
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
>      else
>          *leaf = buffer;
>  #undef BUFFERSIZE
> -#undef buffer
>
>      return dir_handle;
>  }

On Tue, Jun 24, 2025 at 09:33:41AM +0100, Frediano Ziglio wrote:
> On Tue, Jun 24, 2025 at 7:36 AM Frediano Ziglio
> <frediano.ziglio@cloud.com> wrote:
> >
> 
> Typo on title "Do not undefined not defined macro" -> "Do not undefine
> not defined macro"

With typo fixed:

Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

> > The "buffer" macro is not defined.
> > It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff
> > (cfr "xen/keyhandler: Drop keyhandler_scratch").
> >
> > Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> > ---
> >  xen/common/efi/boot.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> > index ded7cc129d..1a9b4e7dae 100644
> > --- a/xen/common/efi/boot.c
> > +++ b/xen/common/efi/boot.c
> > @@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
> >      else
> >          *leaf = buffer;
> >  #undef BUFFERSIZE
> > -#undef buffer
> >
> >      return dir_handle;
> >  }

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

On Tue, Jun 24, 2025 at 01:34:59PM +0200, Marek Marczykowski-Górecki wrote:
> On Tue, Jun 24, 2025 at 09:33:41AM +0100, Frediano Ziglio wrote:
> > On Tue, Jun 24, 2025 at 7:36 AM Frediano Ziglio
> > <frediano.ziglio@cloud.com> wrote:
> > >
> > 
> > Typo on title "Do not undefined not defined macro" -> "Do not undefine
> > not defined macro"
> 
> With typo fixed:
> 
> Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Oh, and maybe:
Fixes: 59e087bf6a9c ("xen/keyhandler: Drop keyhandler_scratch")


> > > The "buffer" macro is not defined.
> > > It was defined till commit 59e087bf6a9c8ad805294c32dfd7c77068d81eff
> > > (cfr "xen/keyhandler: Drop keyhandler_scratch").
> > >
> > > Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> > > ---
> > >  xen/common/efi/boot.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> > > index ded7cc129d..1a9b4e7dae 100644
> > > --- a/xen/common/efi/boot.c
> > > +++ b/xen/common/efi/boot.c
> > > @@ -513,7 +513,6 @@ static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_i
> > >      else
> > >          *leaf = buffer;
> > >  #undef BUFFERSIZE
> > > -#undef buffer
> > >
> > >      return dir_handle;
> > >  }
> 
> -- 
> Best Regards,
> Marek Marczykowski-Górecki
> Invisible Things Lab



-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab