x86/svm: Revert 1->true conversion in svm_asid_handle_vmrun()

[PATCH] x86/svm: Revert 1->true conversion in svm_asid_handle_vmrun()

Andrew Cooper posted 1 patch 4 months, 1 week ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20250623105148.90321-1-andrew.cooper3@citrix.com

xen/arch/x86/hvm/svm/asid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] x86/svm: Revert 1->true conversion in svm_asid_handle_vmrun()

Posted by Andrew Cooper 4 months, 1 week ago

This is literally ASID 1, not a boolean configuration.

Fixes: 2f09f797ba43 ("x86/svm: Drop the suffix _guest from vmcb bit")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/hvm/svm/asid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/svm/asid.c b/xen/arch/x86/hvm/svm/asid.c
index 7977a8e86b53..d5f70f8848be 100644
--- a/xen/arch/x86/hvm/svm/asid.c
+++ b/xen/arch/x86/hvm/svm/asid.c
@@ -37,7 +37,7 @@ void svm_asid_handle_vmrun(void)
     /* ASID 0 indicates that ASIDs are disabled. */
     if ( p_asid->asid == 0 )
     {
-        vmcb_set_asid(vmcb, true);
+        vmcb_set_asid(vmcb, 1);
         vmcb->tlb_control =
             cpu_has_svm_flushbyasid ? TLB_CTRL_FLUSH_ASID : TLB_CTRL_FLUSH_ALL;
         return;

base-commit: cc7394164633e75fb61d52565f75271e0b7f1236
-- 
2.39.5

Re: [PATCH] x86/svm: Revert 1->true conversion in svm_asid_handle_vmrun()

Posted by Jan Beulich 4 months, 1 week ago

On 23.06.2025 12:51, Andrew Cooper wrote:
> This is literally ASID 1, not a boolean configuration.
> 
> Fixes: 2f09f797ba43 ("x86/svm: Drop the suffix _guest from vmcb bit")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>