automation: disable terminal echo in xilinx test scripts

[PATCH v1] automation: disable terminal echo in xilinx test scripts

Posted by victorm.lira@amd.com 4 months, 2 weeks ago

From: Victor Lira <victorm.lira@amd.com>

The default terminal settings in Linux will enable echo which interferes with
these tests. Set the value in the script to avoid failure caused by a settings
reset.

Signed-off-by: Victor Lira <victorm.lira@amd.com>
---
Cc: Michal Orzel <michal.orzel@amd.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
---
 automation/scripts/xilinx-smoke-dom0-x86_64.sh    | 2 +-
 automation/scripts/xilinx-smoke-dom0less-arm64.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/automation/scripts/xilinx-smoke-dom0-x86_64.sh b/automation/scripts/xilinx-smoke-dom0-x86_64.sh
index 71cdb295b2..6970a8658d 100755
--- a/automation/scripts/xilinx-smoke-dom0-x86_64.sh
+++ b/automation/scripts/xilinx-smoke-dom0-x86_64.sh
@@ -165,7 +165,7 @@ sleep 5
 sh /scratch/gitlab-runner/${TEST_BOARD}.sh 1
 sleep 5
 set +e
-stty -F ${SERIAL_DEV} 57600
+stty -F ${SERIAL_DEV} 57600 -echo

 # Capture test result and power off board before exiting.
 export PASSED="${PASS_MSG}"
diff --git a/automation/scripts/xilinx-smoke-dom0less-arm64.sh b/automation/scripts/xilinx-smoke-dom0less-arm64.sh
index 293232eebf..1d7162f1b3 100755
--- a/automation/scripts/xilinx-smoke-dom0less-arm64.sh
+++ b/automation/scripts/xilinx-smoke-dom0less-arm64.sh
@@ -128,7 +128,7 @@ cd $START
 # connect to serial
 SERIAL_DEV="/dev/serial/zynq"
 set +e
-stty -F ${SERIAL_DEV} 115200
+stty -F ${SERIAL_DEV} 115200 -echo

 # Capture test result and power off board before exiting.
 export PASSED="${passed}"
--
2.34.1

Re: [PATCH v1] automation: disable terminal echo in xilinx test scripts

Posted by Stefano Stabellini 4 months, 2 weeks ago

On Tue, 17 Jun 2025, victorm.lira@amd.com wrote:
> From: Victor Lira <victorm.lira@amd.com>
> 
> The default terminal settings in Linux will enable echo which interferes with
> these tests. Set the value in the script to avoid failure caused by a settings
> reset.
> 
> Signed-off-by: Victor Lira <victorm.lira@amd.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Cc: Michal Orzel <michal.orzel@amd.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> ---
>  automation/scripts/xilinx-smoke-dom0-x86_64.sh    | 2 +-
>  automation/scripts/xilinx-smoke-dom0less-arm64.sh | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/automation/scripts/xilinx-smoke-dom0-x86_64.sh b/automation/scripts/xilinx-smoke-dom0-x86_64.sh
> index 71cdb295b2..6970a8658d 100755
> --- a/automation/scripts/xilinx-smoke-dom0-x86_64.sh
> +++ b/automation/scripts/xilinx-smoke-dom0-x86_64.sh
> @@ -165,7 +165,7 @@ sleep 5
>  sh /scratch/gitlab-runner/${TEST_BOARD}.sh 1
>  sleep 5
>  set +e
> -stty -F ${SERIAL_DEV} 57600
> +stty -F ${SERIAL_DEV} 57600 -echo
> 
>  # Capture test result and power off board before exiting.
>  export PASSED="${PASS_MSG}"
> diff --git a/automation/scripts/xilinx-smoke-dom0less-arm64.sh b/automation/scripts/xilinx-smoke-dom0less-arm64.sh
> index 293232eebf..1d7162f1b3 100755
> --- a/automation/scripts/xilinx-smoke-dom0less-arm64.sh
> +++ b/automation/scripts/xilinx-smoke-dom0less-arm64.sh
> @@ -128,7 +128,7 @@ cd $START
>  # connect to serial
>  SERIAL_DEV="/dev/serial/zynq"
>  set +e
> -stty -F ${SERIAL_DEV} 115200
> +stty -F ${SERIAL_DEV} 115200 -echo
> 
>  # Capture test result and power off board before exiting.
>  export PASSED="${passed}"
> --
> 2.34.1
>