On Fri, 13 Jun 2025, Alejandro Vallejo wrote:
> The way they currently include each other, with one of the includes
> being conditional on CONFIG_GRANT_TABLE, makes it hard to know which
> contents are included when.
>
> Break the cycle by removing the asm/grant_table.h include.
>
> Not a functional change because.
>
> Signed-off-by: Alejandro Vallejo <agarciav@amd.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> v3:
> * Strictly remove the cycle in asm/grant_table.h
> (Keeping the conditional include is a terrible idea, IMO)
> ---
> xen/arch/arm/include/asm/grant_table.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h
> index c5d87b60c4..c47058a3a0 100644
> --- a/xen/arch/arm/include/asm/grant_table.h
> +++ b/xen/arch/arm/include/asm/grant_table.h
> @@ -1,7 +1,6 @@
> #ifndef __ASM_GRANT_TABLE_H__
> #define __ASM_GRANT_TABLE_H__
>
> -#include <xen/grant_table.h>
> #include <xen/kernel.h>
> #include <xen/pfn.h>
> #include <xen/sched.h>
> --
> 2.43.0
>