[PATCH] xen/domain: fix late hwdom feature

dmkhn@proton.me posted 1 patch 4 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20250610234105.1082890-1-dmukhin@ford.com
xen/common/domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] xen/domain: fix late hwdom feature
Posted by dmkhn@proton.me 4 months, 3 weeks ago
From: Denis Mukhin <dmukhin@ford.com>

Fix get_initial_domain_id() which how returns hardware_domid and breaks late
hwdom feature [1].

[1] https://lore.kernel.org/xen-devel/a4c860d7-1fa0-43f4-8ae1-af59b7c6506f@xen.org/

Fixes: f147ccf2 ("xen/consoled: clean up console handling for PV shim")
Signed-off-by: Denis Mukhin <dmukhin@ford.com>
---
 xen/common/domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/domain.c b/xen/common/domain.c
index 153cd75340..e566a18747 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -2404,7 +2404,7 @@ domid_t get_initial_domain_id(void)
     if ( pv_shim )
         return pv_shim_get_initial_domain_id();
 #endif
-    return hardware_domid;
+    return 0;
 }
 
 void freeze_domains(void)
-- 
2.34.1
Re: [PATCH] xen/domain: fix late hwdom feature
Posted by Jan Beulich 4 months, 3 weeks ago
On 11.06.2025 01:42, dmkhn@proton.me wrote:
> From: Denis Mukhin <dmukhin@ford.com>
> 
> Fix get_initial_domain_id() which how returns hardware_domid and breaks late
> hwdom feature [1].
> 
> [1] https://lore.kernel.org/xen-devel/a4c860d7-1fa0-43f4-8ae1-af59b7c6506f@xen.org/
> 

Reported-by: Julien Grall <julien@xen.org>

> Fixes: f147ccf2 ("xen/consoled: clean up console handling for PV shim")

12 hex digit please (see sending-patches.pandoc), i.e. f147ccf2b3c8 (largely for
my own reference, to make respective adjustments while committing).

> Signed-off-by: Denis Mukhin <dmukhin@ford.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
Re: [PATCH] xen/domain: fix late hwdom feature
Posted by dmkhn@proton.me 4 months, 2 weeks ago
On Wed, Jun 11, 2025 at 11:20:29AM +0200, Jan Beulich wrote:
> On 11.06.2025 01:42, dmkhn@proton.me wrote:
> > From: Denis Mukhin <dmukhin@ford.com>
> >
> > Fix get_initial_domain_id() which how returns hardware_domid and breaks late
> > hwdom feature [1].
> >
> > [1] https://lore.kernel.org/xen-devel/a4c860d7-1fa0-43f4-8ae1-af59b7c6506f@xen.org/
> >
> 
> Reported-by: Julien Grall <julien@xen.org>
> 
> > Fixes: f147ccf2 ("xen/consoled: clean up console handling for PV shim")
> 
> 12 hex digit please (see sending-patches.pandoc), i.e. f147ccf2b3c8 (largely for
> my own reference, to make respective adjustments while committing).

Thanks; my .gitcofig did not have core.abbrev configured.

> 
> > Signed-off-by: Denis Mukhin <dmukhin@ford.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>

Thank you

>