Revert tools/python part of "tools: remove support for running a guest with qemu-traditional"

[PATCH] Revert tools/python part of "tools: remove support for running a guest with qemu-traditional"

Posted by Andrew Cooper 5 months ago

The migration stream is a stable ABI.  What this does is break the ability to
inspection and operate on pre-Xen-4.21 streams.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
CC: Anthony PERARD <anthony.perard@vates.tech>
CC: Juergen Gross <jgross@suse.com>
---
 tools/python/xen/migration/libxl.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/python/xen/migration/libxl.py b/tools/python/xen/migration/libxl.py
index dc5c7ac3550c..5dcb50fe0207 100644
--- a/tools/python/xen/migration/libxl.py
+++ b/tools/python/xen/migration/libxl.py
@@ -51,10 +51,12 @@ rec_type_to_str = {
 EMULATOR_HEADER_FORMAT = "II"
 
 EMULATOR_ID_unknown       = 0x00000000
+EMULATOR_ID_qemu_trad     = 0x00000001
 EMULATOR_ID_qemu_upstream = 0x00000002
 
 emulator_id_to_str = {
     EMULATOR_ID_unknown       : "Unknown",
+    EMULATOR_ID_qemu_trad     : "Qemu Traditional",
     EMULATOR_ID_qemu_upstream : "Qemu Upstream",
 }
 

base-commit: 286c4cc267005f73aba831d22d65abe6874ceaea
-- 
2.39.5

Re: [PATCH] Revert tools/python part of "tools: remove support for running a guest with qemu-traditional"

Posted by Anthony PERARD 5 months ago

On Mon, Jun 02, 2025 at 12:22:53PM +0100, Andrew Cooper wrote:
> The migration stream is a stable ABI.  What this does is break the ability to
> inspection and operate on pre-Xen-4.21 streams.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Anthony PERARD <anthony.perard@vates.tech>

Thanks,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

Re: [PATCH] Revert tools/python part of "tools: remove support for running a guest with qemu-traditional"

Posted by Marek Marczykowski-Górecki 5 months ago

On Mon, Jun 02, 2025 at 12:22:53PM +0100, Andrew Cooper wrote:
> The migration stream is a stable ABI.  What this does is break the ability to
> inspection and operate on pre-Xen-4.21 streams.

Do you mean Xen 4.21 should be able to accept migration of a domU with
qemu trad? I don't think it's a desirable feature...

> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> CC: Anthony PERARD <anthony.perard@vates.tech>
> CC: Juergen Gross <jgross@suse.com>
> ---
>  tools/python/xen/migration/libxl.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/python/xen/migration/libxl.py b/tools/python/xen/migration/libxl.py
> index dc5c7ac3550c..5dcb50fe0207 100644
> --- a/tools/python/xen/migration/libxl.py
> +++ b/tools/python/xen/migration/libxl.py
> @@ -51,10 +51,12 @@ rec_type_to_str = {
>  EMULATOR_HEADER_FORMAT = "II"
>  
>  EMULATOR_ID_unknown       = 0x00000000
> +EMULATOR_ID_qemu_trad     = 0x00000001
>  EMULATOR_ID_qemu_upstream = 0x00000002
>  
>  emulator_id_to_str = {
>      EMULATOR_ID_unknown       : "Unknown",
> +    EMULATOR_ID_qemu_trad     : "Qemu Traditional",
>      EMULATOR_ID_qemu_upstream : "Qemu Upstream",
>  }
>  
> 
> base-commit: 286c4cc267005f73aba831d22d65abe6874ceaea
> -- 
> 2.39.5
> 

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Re: [PATCH] Revert tools/python part of "tools: remove support for running a guest with qemu-traditional"

Posted by Andrew Cooper 5 months ago

On 02/06/2025 12:27 pm, Marek Marczykowski-Górecki wrote:
> On Mon, Jun 02, 2025 at 12:22:53PM +0100, Andrew Cooper wrote:
>> The migration stream is a stable ABI.  What this does is break the ability to
>> inspection and operate on pre-Xen-4.21 streams.
> Do you mean Xen 4.21 should be able to accept migration of a domU with
> qemu trad? I don't think it's a desirable feature...

xl is free to reject a qemu-trad stream if it wants.

What's not ok is verify-stream-v2 exploding with "unknown emulator 1"
when I ask it to tell me what the bytes in this stream mean.

~Andrew

Re: [PATCH] Revert tools/python part of "tools: remove support for running a guest with qemu-traditional"

Posted by Marek Marczykowski-Górecki 4 months, 4 weeks ago

On Mon, Jun 02, 2025 at 12:31:59PM +0100, Andrew Cooper wrote:
> On 02/06/2025 12:27 pm, Marek Marczykowski-Górecki wrote:
> > On Mon, Jun 02, 2025 at 12:22:53PM +0100, Andrew Cooper wrote:
> >> The migration stream is a stable ABI.  What this does is break the ability to
> >> inspection and operate on pre-Xen-4.21 streams.
> > Do you mean Xen 4.21 should be able to accept migration of a domU with
> > qemu trad? I don't think it's a desirable feature...
> 
> xl is free to reject a qemu-trad stream if it wants.
> 
> What's not ok is verify-stream-v2 exploding with "unknown emulator 1"
> when I ask it to tell me what the bytes in this stream mean.

I see, in that case:

Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab