[PATCH] tools/tests: Add install target for vPCI

Andrew Cooper posted 1 patch 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20250530104307.2550886-1-andrew.cooper3@citrix.com
tools/tests/vpci/Makefile | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
[PATCH] tools/tests: Add install target for vPCI
Posted by Andrew Cooper 5 months ago
This lets it run automagically in CI.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Anthony PERARD <anthony.perard@vates.tech>
---
 tools/tests/vpci/Makefile | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/tests/vpci/Makefile b/tools/tests/vpci/Makefile
index 62f21f341a01..9450f7593a41 100644
--- a/tools/tests/vpci/Makefile
+++ b/tools/tests/vpci/Makefile
@@ -21,7 +21,13 @@ clean:
 distclean: clean
 
 .PHONY: install
-install:
+install: all
+	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC)/tests
+	$(INSTALL_PROG) $(TARGET) $(DESTDIR)$(LIBEXEC)/tests
+
+.PHONY: uninstall
+uninstall:
+	$(RM) -- $(DESTDIR)$(LIBEXEC)/tests/$(TARGET)
 
 vpci.c: $(XEN_ROOT)/xen/drivers/vpci/vpci.c
 	# Remove includes and add the test harness header
-- 
2.39.5


Re: [PATCH] tools/tests: Add install target for vPCI
Posted by Roger Pau Monné 5 months ago
On Fri, May 30, 2025 at 11:43:07AM +0100, Andrew Cooper wrote:
> This lets it run automagically in CI.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

I had sent something similar long time ago:

https://lore.kernel.org/xen-devel/20230313121226.86557-1-roger.pau@citrix.com/

But got no reviews.

Thanks, Roger.

Re: [PATCH] tools/tests: Add install target for vPCI
Posted by Andrew Cooper 5 months ago
On 30/05/2025 11:57 am, Roger Pau Monné wrote:
> On Fri, May 30, 2025 at 11:43:07AM +0100, Andrew Cooper wrote:
>> This lets it run automagically in CI.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>
> I had sent something similar long time ago:
>
> https://lore.kernel.org/xen-devel/20230313121226.86557-1-roger.pau@citrix.com/
>
> But got no reviews.
>
> Thanks, Roger.

Sorry, that fell through the cracks too.

What I'll do if you're happy is submit it as authored by you but with
this content (seeing as it's the one I've tested in the past week), and
A-by me.

~Andrew

Re: [PATCH] tools/tests: Add install target for vPCI
Posted by Roger Pau Monné 5 months ago
On Fri, May 30, 2025 at 01:29:49PM +0100, Andrew Cooper wrote:
> On 30/05/2025 11:57 am, Roger Pau Monné wrote:
> > On Fri, May 30, 2025 at 11:43:07AM +0100, Andrew Cooper wrote:
> >> This lets it run automagically in CI.
> >>
> >> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> >
> > I had sent something similar long time ago:
> >
> > https://lore.kernel.org/xen-devel/20230313121226.86557-1-roger.pau@citrix.com/
> >
> > But got no reviews.
> >
> > Thanks, Roger.
> 
> Sorry, that fell through the cracks too.
> 
> What I'll do if you're happy is submit it as authored by you but with
> this content (seeing as it's the one I've tested in the past week), and
> A-by me.

Oh, no worries about authorship, you can just commit this one really.

Thanks, Roger.