CI/eclair: Remove ARM64 custom clean rules

[PATCH] CI/eclair: Remove ARM64 custom clean rules

Posted by Andrew Cooper 8 months, 3 weeks ago

Rules 5.3, 11.2 and 16.6 are already listed in clean_guidelines_common and
apply to all architectures.  There's no need for arm64 to give them a second
time.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: consulting@bugseng.com <consulting@bugseng.com>
CC: Nicola Vetrini <nicola.vetrini@bugseng.com>

I've left the x86/arm split as-before so it's easier for those not familiar
with Eclair syntax to add per-arch configuruation.
---
 automation/eclair_analysis/ECLAIR/tagging.ecl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl b/automation/eclair_analysis/ECLAIR/tagging.ecl
index 7e3095423b79..b95f07feb099 100644
--- a/automation/eclair_analysis/ECLAIR/tagging.ecl
+++ b/automation/eclair_analysis/ECLAIR/tagging.ecl
@@ -122,7 +122,7 @@ if(string_equal(target,"x86_64"),
 )
 
 if(string_equal(target,"arm64"),
-    service_selector({"additional_clean_guidelines","MC3A2.R5.3||MC3.R11.2||MC3A2.R16.6"})
+    service_selector({"additional_clean_guidelines","none()"})
 )
 
 -reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"}

base-commit: 6fc02ebdd053856221f37ba5306232ac1575332d
prerequisite-patch-id: 7bc1c498ba2c9c4a4939a56a0006f820f47f2a66
prerequisite-patch-id: 8fcd84101ab012ed0aa427c30eca564c5ac10726
-- 
2.39.5

Re: [PATCH] CI/eclair: Remove ARM64 custom clean rules

Posted by Nicola Vetrini 8 months, 3 weeks ago

On 2025-05-19 16:07, Andrew Cooper wrote:
> Rules 5.3, 11.2 and 16.6 are already listed in clean_guidelines_common 
> and
> apply to all architectures.  There's no need for arm64 to give them a 
> second
> time.
> 

Thanks.

> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Nicola Vetrini <nicola.vetrini@bugseng.com>

> ---
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: consulting@bugseng.com <consulting@bugseng.com>
> CC: Nicola Vetrini <nicola.vetrini@bugseng.com>
> 
> I've left the x86/arm split as-before so it's easier for those not 
> familiar
> with Eclair syntax to add per-arch configuruation.
> ---
>  automation/eclair_analysis/ECLAIR/tagging.ecl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl 
> b/automation/eclair_analysis/ECLAIR/tagging.ecl
> index 7e3095423b79..b95f07feb099 100644
> --- a/automation/eclair_analysis/ECLAIR/tagging.ecl
> +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl
> @@ -122,7 +122,7 @@ if(string_equal(target,"x86_64"),
>  )
> 
>  if(string_equal(target,"arm64"),
> -    
> service_selector({"additional_clean_guidelines","MC3A2.R5.3||MC3.R11.2||MC3A2.R16.6"})
> +    service_selector({"additional_clean_guidelines","none()"})
>  )
> 
>  
> -reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"}
> 
> base-commit: 6fc02ebdd053856221f37ba5306232ac1575332d
> prerequisite-patch-id: 7bc1c498ba2c9c4a4939a56a0006f820f47f2a66
> prerequisite-patch-id: 8fcd84101ab012ed0aa427c30eca564c5ac10726

-- 
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253

Re: [PATCH] CI/eclair: Remove ARM64 custom clean rules

Posted by Stefano Stabellini 8 months, 3 weeks ago

On Mon, 19 May 2025, Nicola Vetrini wrote:
> On 2025-05-19 16:07, Andrew Cooper wrote:
> > Rules 5.3, 11.2 and 16.6 are already listed in clean_guidelines_common and
> > apply to all architectures.  There's no need for arm64 to give them a second
> > time.
> > 
> 
> Thanks.
> 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Nicola Vetrini <nicola.vetrini@bugseng.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> > ---
> > CC: Stefano Stabellini <sstabellini@kernel.org>
> > CC: consulting@bugseng.com <consulting@bugseng.com>
> > CC: Nicola Vetrini <nicola.vetrini@bugseng.com>
> > 
> > I've left the x86/arm split as-before so it's easier for those not familiar
> > with Eclair syntax to add per-arch configuruation.
> > ---
> >  automation/eclair_analysis/ECLAIR/tagging.ecl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl
> > b/automation/eclair_analysis/ECLAIR/tagging.ecl
> > index 7e3095423b79..b95f07feb099 100644
> > --- a/automation/eclair_analysis/ECLAIR/tagging.ecl
> > +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl
> > @@ -122,7 +122,7 @@ if(string_equal(target,"x86_64"),
> >  )
> > 
> >  if(string_equal(target,"arm64"),
> > -
> > service_selector({"additional_clean_guidelines","MC3A2.R5.3||MC3.R11.2||MC3A2.R16.6"})
> > +    service_selector({"additional_clean_guidelines","none()"})
> >  )
> > 
> > 
> > -reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"}
> > 
> > base-commit: 6fc02ebdd053856221f37ba5306232ac1575332d
> > prerequisite-patch-id: 7bc1c498ba2c9c4a4939a56a0006f820f47f2a66
> > prerequisite-patch-id: 8fcd84101ab012ed0aa427c30eca564c5ac10726
> 
> -- 
> Nicola Vetrini, B.Sc.
> Software Engineer
> BUGSENG (https://bugseng.com)
> LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
>