[PATCH] xen: Drop CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE

Andrew Cooper posted 1 patch 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20250422113537.1286981-1-andrew.cooper3@citrix.com
xen/Kconfig                | 4 ----
xen/include/xen/compiler.h | 2 --
2 files changed, 6 deletions(-)
[PATCH] xen: Drop CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE
Posted by Andrew Cooper 8 months ago
All supported toolchains now have it.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Anthony PERARD <anthony.perard@vates.tech>
CC: Michal Orzel <michal.orzel@amd.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
---
 xen/Kconfig                | 4 ----
 xen/include/xen/compiler.h | 2 --
 2 files changed, 6 deletions(-)

diff --git a/xen/Kconfig b/xen/Kconfig
index 72fdb8376087..ae1c401a981e 100644
--- a/xen/Kconfig
+++ b/xen/Kconfig
@@ -29,10 +29,6 @@ config LD_IS_GNU
 config LD_IS_LLVM
 	def_bool $(success,$(LD) --version | head -n 1 | grep -q "^LLD")
 
-# -fvisibility=hidden reduces -fpic cost, if it's available
-config CC_HAS_VISIBILITY_ATTRIBUTE
-	def_bool $(cc-option,-fvisibility=hidden)
-
 # Use -f{function,data}-sections compiler parameters
 config CC_SPLIT_SECTIONS
 	bool
diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h
index 38b8fa3d386d..c68fab189154 100644
--- a/xen/include/xen/compiler.h
+++ b/xen/include/xen/compiler.h
@@ -17,10 +17,8 @@
 
 #endif /* Compiler checks. */
 
-#ifdef CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE
 /* Results in more efficient PIC code (no indirections through GOT or PLT). */
 #pragma GCC visibility push(hidden)
-#endif
 
 #define barrier()     __asm__ __volatile__("": : :"memory")
 
-- 
2.39.5


Re: [PATCH] xen: Drop CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE
Posted by Jan Beulich 8 months ago
On 22.04.2025 13:35, Andrew Cooper wrote:
> All supported toolchains now have it.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>