Use of setjmp/longjmp as removed in 2006, but the include remained.
Remove it now.

Fixes: 1bac3b49cd ("Import the current version of talloc...")
Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
---
I truncated the Fixes above.  The full line is:
Fixes: 1bac3b49cd ("Import the current version of talloc from the Samba 3 source base.  This gives us greater confidence that our talloc implementation is "known good".  Remove the OOM handling from consider_message: talloc_set_fail_handler is no longer supported.")
---
 tools/xenstored/core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c
index 91b2530e5c..835402af81 100644
--- a/tools/xenstored/core.c
+++ b/tools/xenstored/core.c
@@ -35,7 +35,6 @@
 #include <getopt.h>
 #include <signal.h>
 #include <assert.h>
-#include <setjmp.h>
 
 #include <xenevtchn.h>
 #include <xen-tools/xenstore-common.h>
-- 
2.49.0

On 18.04.25 22:59, Jason Andryuk wrote:
> Use of setjmp/longjmp as removed in 2006, but the include remained.
> Remove it now.
> 
> Fixes: 1bac3b49cd ("Import the current version of talloc...")
> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>

Apart from the Fixes: commit id shortening:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

Hi Jason,

On 19/04/2025 05:59, Jason Andryuk wrote:
> Use of setjmp/longjmp as removed in 2006, but the include remained.
> Remove it now.
> 
> Fixes: 1bac3b49cd ("Import the current version of talloc...")

The subject truncation is ok however for the commit ID, we are expecting 
12 characters (see docs/process/sending-patches.pandoc).


> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>

With the remark above addressed (can be fixed on commit):

Reviewed-by: Julien Grall <jgrall@amazon.com>

> ---
> I truncated the Fixes above.  The full line is:
> Fixes: 1bac3b49cd ("Import the current version of talloc from the Samba 3 source base.  This gives us greater confidence that our talloc implementation is "known good".  Remove the OOM handling from consider_message: talloc_set_fail_handler is no longer supported.")
 > --->   tools/xenstored/core.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c
> index 91b2530e5c..835402af81 100644
> --- a/tools/xenstored/core.c
> +++ b/tools/xenstored/core.c
> @@ -35,7 +35,6 @@
>   #include <getopt.h>
>   #include <signal.h>
>   #include <assert.h>
> -#include <setjmp.h>
>   
>   #include <xenevtchn.h>
>   #include <xen-tools/xenstore-common.h>

Cheers,

-- 
Julien Grall

On Fri, Apr 18, 2025 at 6:51 PM Julien Grall <julien@xen.org> wrote:
>
> Hi Jason,
>
> On 19/04/2025 05:59, Jason Andryuk wrote:
> > Use of setjmp/longjmp as removed in 2006, but the include remained.

Whoops, this should be "was removed".

> > Remove it now.
> >
> > Fixes: 1bac3b49cd ("Import the current version of talloc...")
>
> The subject truncation is ok however for the commit ID, we are expecting
> 12 characters (see docs/process/sending-patches.pandoc).

Sorry about that.  I used `--pretty=fixes`, but I guess I have it
misconfigured on that machine.

The 12 character ID is:
1bac3b49cdd4

>
> > Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
>
> With the remark above addressed (can be fixed on commit):
>
> Reviewed-by: Julien Grall <jgrall@amazon.com>

Thanks,
Jason