xen: Change xen-acpi-processor dom0 dependency

[PATCH] xen: Change xen-acpi-processor dom0 dependency

Posted by Jason Andryuk 7 months ago

xen-acpi-processor functions under a PVH dom0 with only a
xen_initial_domain() runtime check.  Change the Kconfig dependency from
PV dom0 to generic dom0 to reflect that.

Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
---
 drivers/xen/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index f7d6f47971fd..24f485827e03 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -278,7 +278,7 @@ config XEN_PRIVCMD_EVENTFD
 
 config XEN_ACPI_PROCESSOR
 	tristate "Xen ACPI processor"
-	depends on XEN && XEN_PV_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
+	depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
 	default m
 	help
 	  This ACPI processor uploads Power Management information to the Xen
-- 
2.49.0

Re: [PATCH] xen: Change xen-acpi-processor dom0 dependency

Posted by Jürgen Groß 7 months ago

On 31.03.25 19:29, Jason Andryuk wrote:
> xen-acpi-processor functions under a PVH dom0 with only a
> xen_initial_domain() runtime check.  Change the Kconfig dependency from
> PV dom0 to generic dom0 to reflect that.
> 
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
> ---
>   drivers/xen/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index f7d6f47971fd..24f485827e03 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -278,7 +278,7 @@ config XEN_PRIVCMD_EVENTFD
>   
>   config XEN_ACPI_PROCESSOR
>   	tristate "Xen ACPI processor"
> -	depends on XEN && XEN_PV_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
> +	depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
>   	default m
>   	help
>   	  This ACPI processor uploads Power Management information to the Xen

Assuming that all needed hypercalls are fine for PVH dom0:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

Re: [PATCH] xen: Change xen-acpi-processor dom0 dependency

Posted by Jan Beulich 7 months ago

On 02.04.2025 16:24, Jürgen Groß wrote:
> On 31.03.25 19:29, Jason Andryuk wrote:
>> xen-acpi-processor functions under a PVH dom0 with only a
>> xen_initial_domain() runtime check.  Change the Kconfig dependency from
>> PV dom0 to generic dom0 to reflect that.
>>
>> Suggested-by: Jan Beulich <jbeulich@suse.com>
>> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
>> ---
>>   drivers/xen/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>> index f7d6f47971fd..24f485827e03 100644
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -278,7 +278,7 @@ config XEN_PRIVCMD_EVENTFD
>>   
>>   config XEN_ACPI_PROCESSOR
>>   	tristate "Xen ACPI processor"
>> -	depends on XEN && XEN_PV_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
>> +	depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
>>   	default m
>>   	help
>>   	  This ACPI processor uploads Power Management information to the Xen
> 
> Assuming that all needed hypercalls are fine for PVH dom0:

If you want to feel further ascertained, you could also add
Tested-by: Jan Beulich <jbeulich@suse.com>
even if that was only in the context of "xen/acpi: upload power and
performance related data from a PVH dom0", where I noticed this issue.

Jan

Re: [PATCH] xen: Change xen-acpi-processor dom0 dependency

Posted by Jason Andryuk 7 months ago

On 2025-04-02 10:24, Jürgen Groß wrote:
> On 31.03.25 19:29, Jason Andryuk wrote:
>> xen-acpi-processor functions under a PVH dom0 with only a
>> xen_initial_domain() runtime check.  Change the Kconfig dependency from
>> PV dom0 to generic dom0 to reflect that.
>>
>> Suggested-by: Jan Beulich <jbeulich@suse.com>
>> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
>> ---
>>   drivers/xen/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>> index f7d6f47971fd..24f485827e03 100644
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -278,7 +278,7 @@ config XEN_PRIVCMD_EVENTFD
>>   config XEN_ACPI_PROCESSOR
>>       tristate "Xen ACPI processor"
>> -    depends on XEN && XEN_PV_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
>> +    depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
>>       default m
>>       help
>>         This ACPI processor uploads Power Management information to 
>> the Xen
> 
> Assuming that all needed hypercalls are fine for PVH dom0:

It's platform_op XENPF_set_processor_pminfo and XENPF_get_cpuinfo.  Xen 
doesn't check if the caller is PV or PVH.

> Reviewed-by: Juergen Gross <jgross@suse.com>

Thanks, Juergen.

-Jason