IOMMU/VT-d: Fix comment

[PATCH] IOMMU/VT-d: Fix comment

Andrew Cooper posted 1 patch 5 days, 16 hours ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20250303221438.2495688-1-andrew.cooper3@citrix.com

xen/drivers/passthrough/vtd/intremap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] IOMMU/VT-d: Fix comment

Posted by Andrew Cooper 5 days, 16 hours ago

"find upstream bridge" is surprisingly jarring in context, considering that's
the name of the function who's return value we're testing.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/drivers/passthrough/vtd/intremap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthrough/vtd/intremap.c
index 820616a8de93..1aeaeb5ec595 100644
--- a/xen/drivers/passthrough/vtd/intremap.c
+++ b/xen/drivers/passthrough/vtd/intremap.c
@@ -475,7 +475,7 @@ static void set_msi_source_id(struct pci_dev *pdev, struct iremap_entry *ire)
             set_ire_sid(ire, SVT_VERIFY_SID_SQ, SQ_ALL_16,
                         PCI_BDF(bus, devfn));
         }
-        else if ( ret == 1 ) /* find upstream bridge */
+        else if ( ret == 1 ) /* found upstream bridge */
         {
             if ( pdev_type(seg, bus, devfn) == DEV_TYPE_PCIe2PCI_BRIDGE )
                 set_ire_sid(ire, SVT_VERIFY_BUS, SQ_ALL_16,

base-commit: e95dc03717b8ae00de2a0b41b88905af6170b210
-- 
2.39.5

Re: [PATCH] IOMMU/VT-d: Fix comment

Posted by Roger Pau Monné 5 days, 5 hours ago

On Mon, Mar 03, 2025 at 10:14:38PM +0000, Andrew Cooper wrote:
> "find upstream bridge" is surprisingly jarring in context, considering that's
> the name of the function who's return value we're testing.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.