ioreq: fix check for CONFIG_ARCH_VCPU_IOREQ_COMPLETION

[XEN PATCH] ioreq: fix check for CONFIG_ARCH_VCPU_IOREQ_COMPLETION

Sergiy Kibrik posted 1 patch 1 month, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20241219111326.3031000-1-Sergiy._5FKibrik@epam.com

xen/arch/x86/hvm/ioreq.c | 2 +-
xen/include/xen/ioreq.h  | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[XEN PATCH] ioreq: fix check for CONFIG_ARCH_VCPU_IOREQ_COMPLETION

Posted by Sergiy Kibrik 1 month, 2 weeks ago

It should be CONFIG_ARCH_VCPU_IOREQ_COMPLETION (as in Kconfig) and not
misspelled CONFIG_VCPU_ARCH_IOREQ_COMPLETION.
Bug introduced by:

979cfdd3e5 ioreq: do not build arch_vcpu_ioreq_completion() for non-VMX configurations

Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
---
 xen/arch/x86/hvm/ioreq.c | 2 +-
 xen/include/xen/ioreq.h  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c
index 5c3d0c69aa..d6491df8e7 100644
--- a/xen/arch/x86/hvm/ioreq.c
+++ b/xen/arch/x86/hvm/ioreq.c
@@ -29,7 +29,7 @@ bool arch_ioreq_complete_mmio(void)
     return handle_mmio();
 }
 
-#ifdef CONFIG_VCPU_ARCH_IOREQ_COMPLETION
+#ifdef CONFIG_ARCH_VCPU_IOREQ_COMPLETION
 bool arch_vcpu_ioreq_completion(enum vio_completion completion)
 {
     switch ( completion )
diff --git a/xen/include/xen/ioreq.h b/xen/include/xen/ioreq.h
index 29a17e8ff5..4f3c6b598d 100644
--- a/xen/include/xen/ioreq.h
+++ b/xen/include/xen/ioreq.h
@@ -112,7 +112,7 @@ int ioreq_server_dm_op(struct xen_dm_op *op, struct domain *d, bool *const_op);
 
 bool arch_ioreq_complete_mmio(void);
 
-#ifdef CONFIG_VCPU_ARCH_IOREQ_COMPLETION
+#ifdef CONFIG_ARCH_VCPU_IOREQ_COMPLETION
 bool arch_vcpu_ioreq_completion(enum vio_completion completion);
 #else
 static inline bool arch_vcpu_ioreq_completion(enum vio_completion completion)
-- 
2.25.1

Re: [XEN PATCH] ioreq: fix check for CONFIG_ARCH_VCPU_IOREQ_COMPLETION

Posted by Andrew Cooper 1 month, 2 weeks ago

On 19/12/2024 11:13 am, Sergiy Kibrik wrote:
> It should be CONFIG_ARCH_VCPU_IOREQ_COMPLETION (as in Kconfig) and not
> misspelled CONFIG_VCPU_ARCH_IOREQ_COMPLETION.
> Bug introduced by:
>
> 979cfdd3e5 ioreq: do not build arch_vcpu_ioreq_completion() for non-VMX configurations
>
> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>