uboot-script-gen: Use split_value for memory

[ImageBuilder] uboot-script-gen: Use split_value for memory

Posted by Jason Andryuk 3 weeks, 4 days ago

Don't hardcode the first cell to 0 - use split_value to handle larger
values properly.

Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
---
 scripts/uboot-script-gen | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
index f10e5f4..dcf5bdb 100755
--- a/scripts/uboot-script-gen
+++ b/scripts/uboot-script-gen
@@ -174,7 +174,7 @@ function add_device_tree_mem()
         memory=$((512 * 1024))
     fi
 
-    dt_set "$path" "memory" "int" "0 $memory"
+    dt_set "$path" "memory" "int" "$( split_value $memory )"
 }
 
 function add_device_tree_static_mem()
-- 
2.34.1

Re: [ImageBuilder] uboot-script-gen: Use split_value for memory

Posted by Stefano Stabellini 3 weeks, 4 days ago

On Mon, 28 Oct 2024, Jason Andryuk wrote:
> Don't hardcode the first cell to 0 - use split_value to handle larger
> values properly.
> 
> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  scripts/uboot-script-gen | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
> index f10e5f4..dcf5bdb 100755
> --- a/scripts/uboot-script-gen
> +++ b/scripts/uboot-script-gen
> @@ -174,7 +174,7 @@ function add_device_tree_mem()
>          memory=$((512 * 1024))
>      fi
>  
> -    dt_set "$path" "memory" "int" "0 $memory"
> +    dt_set "$path" "memory" "int" "$( split_value $memory )"
>  }
>  
>  function add_device_tree_static_mem()
> -- 
> 2.34.1
>