This changes the type for the initrd parameter of dom0_construct_pv to be struct
boot_module. This conversion requires several adjustments throughout dom0_construct_pv
to account for the type change. Removes the usage of early_mod field for ramdisk module.
Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
---
Changes since v6:
- removed unnecessary indentation changes
Changes since v5:
- changed initrd_mfn initialization to _mfn(0)
---
xen/arch/x86/dom0_build.c | 2 +-
xen/arch/x86/include/asm/dom0_build.h | 2 +-
xen/arch/x86/pv/dom0_build.c | 29 +++++++++++++++------------
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c
index 54db578dd29f..1d05ee53a6d8 100644
--- a/xen/arch/x86/dom0_build.c
+++ b/xen/arch/x86/dom0_build.c
@@ -613,7 +613,7 @@ int __init construct_dom0(struct domain *d, const struct boot_module *image,
rc = dom0_construct_pvh(d, image->mod, image->headroom, initrd->mod,
cmdline);
else if ( is_pv_domain(d) )
- rc = dom0_construct_pv(d, image, initrd->mod, cmdline);
+ rc = dom0_construct_pv(d, image, initrd, cmdline);
else
panic("Cannot construct Dom0. No guest interface available\n");
diff --git a/xen/arch/x86/include/asm/dom0_build.h b/xen/arch/x86/include/asm/dom0_build.h
index 66ea70869c49..3ddd22fad2ba 100644
--- a/xen/arch/x86/include/asm/dom0_build.h
+++ b/xen/arch/x86/include/asm/dom0_build.h
@@ -14,7 +14,7 @@ unsigned long dom0_compute_nr_pages(struct domain *d,
int dom0_setup_permissions(struct domain *d);
int dom0_construct_pv(struct domain *d, const struct boot_module *image,
- module_t *initrd,
+ struct boot_module *initrd,
const char *cmdline);
int dom0_construct_pvh(struct domain *d, const module_t *image,
diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c
index db4c066e626b..45a386aa81f0 100644
--- a/xen/arch/x86/pv/dom0_build.c
+++ b/xen/arch/x86/pv/dom0_build.c
@@ -356,7 +356,7 @@ static struct page_info * __init alloc_chunk(struct domain *d,
static int __init dom0_construct(struct domain *d,
const struct boot_module *image,
- module_t *initrd,
+ struct boot_module *initrd,
const char *cmdline)
{
int i, rc, order, machine;
@@ -367,7 +367,8 @@ static int __init dom0_construct(struct domain *d,
unsigned long nr_pt_pages;
unsigned long alloc_spfn;
unsigned long alloc_epfn;
- unsigned long initrd_pfn = -1, initrd_mfn = 0;
+ unsigned long initrd_pfn = -1;
+ mfn_t initrd_mfn = _mfn(0);
unsigned long count;
struct page_info *page = NULL;
unsigned int flush_flags = 0;
@@ -376,7 +377,7 @@ static int __init dom0_construct(struct domain *d,
void *image_base = bootstrap_map_bm(image);
unsigned long image_len = image->size;
void *image_start = image_base + image->headroom;
- unsigned long initrd_len = initrd ? initrd->mod_end : 0;
+ unsigned long initrd_len = initrd ? initrd->size : 0;
l4_pgentry_t *l4tab = NULL, *l4start = NULL;
l3_pgentry_t *l3tab = NULL, *l3start = NULL;
l2_pgentry_t *l2tab = NULL, *l2start = NULL;
@@ -612,7 +613,8 @@ static int __init dom0_construct(struct domain *d,
initrd_pfn = vinitrd_start ?
(vinitrd_start - v_start) >> PAGE_SHIFT :
domain_tot_pages(d);
- initrd_mfn = mfn = initrd->mod_start;
+ initrd_mfn = maddr_to_mfn(initrd->start);
+ mfn = mfn_x(initrd_mfn);
count = PFN_UP(initrd_len);
if ( d->arch.physaddr_bitsize &&
((mfn + count - 1) >> (d->arch.physaddr_bitsize - PAGE_SHIFT)) )
@@ -627,12 +629,13 @@ static int __init dom0_construct(struct domain *d,
free_domheap_pages(page, order);
page += 1UL << order;
}
- memcpy(page_to_virt(page), mfn_to_virt(initrd->mod_start),
+ memcpy(page_to_virt(page), maddr_to_virt(initrd->start),
initrd_len);
- mpt_alloc = (paddr_t)initrd->mod_start << PAGE_SHIFT;
+ mpt_alloc = initrd->start;
init_domheap_pages(mpt_alloc,
mpt_alloc + PAGE_ALIGN(initrd_len));
- initrd->mod_start = initrd_mfn = mfn_x(page_to_mfn(page));
+ initrd_mfn = page_to_mfn(page);
+ initrd->start = mfn_to_maddr(initrd_mfn);
}
else
{
@@ -640,9 +643,9 @@ static int __init dom0_construct(struct domain *d,
if ( assign_pages(mfn_to_page(_mfn(mfn++)), 1, d, 0) )
BUG();
}
- initrd->mod_end = 0;
+ initrd->size = 0;
- iommu_memory_setup(d, "initrd", mfn_to_page(_mfn(initrd_mfn)),
+ iommu_memory_setup(d, "initrd", mfn_to_page(initrd_mfn),
PFN_UP(initrd_len), &flush_flags);
}
@@ -654,7 +657,7 @@ static int __init dom0_construct(struct domain *d,
nr_pages - domain_tot_pages(d));
if ( initrd )
{
- mpt_alloc = (paddr_t)initrd->mod_start << PAGE_SHIFT;
+ mpt_alloc = initrd->start;
printk("\n Init. ramdisk: %"PRIpaddr"->%"PRIpaddr,
mpt_alloc, mpt_alloc + initrd_len);
}
@@ -763,7 +766,7 @@ static int __init dom0_construct(struct domain *d,
if ( count < initrd_pfn || count >= initrd_pfn + PFN_UP(initrd_len) )
mfn = pfn++;
else
- mfn = initrd_mfn++;
+ mfn = mfn_x(initrd_mfn) + 1;
*l1tab = l1e_from_pfn(mfn, compat ? COMPAT_L1_PROT : L1_PROT);
l1tab++;
@@ -882,7 +885,7 @@ static int __init dom0_construct(struct domain *d,
if ( pfn >= initrd_pfn )
{
if ( pfn < initrd_pfn + PFN_UP(initrd_len) )
- mfn = initrd->mod_start + (pfn - initrd_pfn);
+ mfn = paddr_to_pfn(initrd->start) + (pfn - initrd_pfn);
else
mfn -= PFN_UP(initrd_len);
}
@@ -1052,7 +1055,7 @@ out:
int __init dom0_construct_pv(struct domain *d,
const struct boot_module *image,
- module_t *initrd,
+ struct boot_module *initrd,
const char *cmdline)
{
unsigned long cr4 = read_cr4();
--
2.30.2