Add a char pointer field, cmdline, to struct boot_module to hold the address
pointed to by the string field of struct mod. This removes the need to use the
early_mod field to get to the dom0 kernel command line.
Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
Changes since v5:
- changed boot_module element cmdline to paddr_t
---
xen/arch/x86/include/asm/bootinfo.h | 2 ++
xen/arch/x86/setup.c | 9 ++++++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h
index 9bd0e6336b4a..941363601db7 100644
--- a/xen/arch/x86/include/asm/bootinfo.h
+++ b/xen/arch/x86/include/asm/bootinfo.h
@@ -52,6 +52,8 @@ struct boot_module {
bool relocated:1;
bool consumed:1;
+ paddr_t cmdline;
+
paddr_t start;
size_t size;
};
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 6f953edd7521..254aeb0c5e1b 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -318,6 +318,8 @@ static struct boot_info *__init multiboot_fill_boot_info(unsigned long mbi_p)
{
bi->mods[i].mod = &mods[i];
+ bi->mods[i].cmdline = (paddr_t)mods[i].string;
+
if ( !efi_enabled(EFI_LOADER) )
{
bi->mods[i].start = mods[i].mod_start;
@@ -1016,10 +1018,11 @@ static struct domain *__init create_dom0(struct boot_info *bi)
panic("Error creating d%uv0\n", domid);
/* Grab the DOM0 command line. */
- if ( image->mod->string || bi->kextra )
+ if ( image->cmdline || bi->kextra )
{
- if ( image->mod->string )
- safe_strcpy(cmdline, cmdline_cook(__va(image->mod->string),
+ if ( image->cmdline )
+ safe_strcpy(cmdline,
+ cmdline_cook(__va(image->cmdline),
bi->loader));
if ( bi->kextra )
--
2.30.2