[PATCH v2 6/6] dt-overlay: Print overlay I/O memory ranges in hex

Michal Orzel posted 6 patches 1 year ago
[PATCH v2 6/6] dt-overlay: Print overlay I/O memory ranges in hex
Posted by Michal Orzel 1 year ago
Printing I/O memory rangeset ranges in decimal is not very helpful when
debugging, so switch to hex by adding RANGESETF_prettyprint_hex flag
for iomem_ranges rangeset.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
Changes in v2:
 - New patch
---
 xen/common/dt-overlay.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/common/dt-overlay.c b/xen/common/dt-overlay.c
index 4d75b5b36a99..5ce00514ef14 100644
--- a/xen/common/dt-overlay.c
+++ b/xen/common/dt-overlay.c
@@ -869,7 +869,8 @@ static long handle_attach_overlay_nodes(struct domain *d,
         goto out;
     }
 
-    entry->iomem_ranges = rangeset_new(d, "Overlay: I/O Memory", 0);
+    entry->iomem_ranges = rangeset_new(d, "Overlay: I/O Memory",
+                                       RANGESETF_prettyprint_hex);
     if (entry->iomem_ranges == NULL)
     {
         rc = -ENOMEM;
-- 
2.25.1
Re: [PATCH v2 6/6] dt-overlay: Print overlay I/O memory ranges in hex
Posted by Stefano Stabellini 1 year ago
On Fri, 4 Oct 2024, Michal Orzel wrote:
> Printing I/O memory rangeset ranges in decimal is not very helpful when
> debugging, so switch to hex by adding RANGESETF_prettyprint_hex flag
> for iomem_ranges rangeset.
> 
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes in v2:
>  - New patch
> ---
>  xen/common/dt-overlay.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/dt-overlay.c b/xen/common/dt-overlay.c
> index 4d75b5b36a99..5ce00514ef14 100644
> --- a/xen/common/dt-overlay.c
> +++ b/xen/common/dt-overlay.c
> @@ -869,7 +869,8 @@ static long handle_attach_overlay_nodes(struct domain *d,
>          goto out;
>      }
>  
> -    entry->iomem_ranges = rangeset_new(d, "Overlay: I/O Memory", 0);
> +    entry->iomem_ranges = rangeset_new(d, "Overlay: I/O Memory",
> +                                       RANGESETF_prettyprint_hex);
>      if (entry->iomem_ranges == NULL)
>      {
>          rc = -ENOMEM;
> -- 
> 2.25.1
>