[PATCH 5/5] ARM/cache: Drop legacy __read_mostly/__ro_after_init definitions

Andrew Cooper posted 5 patches 2 months, 2 weeks ago
[PATCH 5/5] ARM/cache: Drop legacy __read_mostly/__ro_after_init definitions
Posted by Andrew Cooper 2 months, 2 weeks ago
These are no longer needed.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Michal Orzel <michal.orzel@amd.com>
---
 xen/arch/arm/include/asm/cache.h | 3 ---
 xen/include/xen/cache.h          | 5 -----
 2 files changed, 8 deletions(-)

diff --git a/xen/arch/arm/include/asm/cache.h b/xen/arch/arm/include/asm/cache.h
index 029b2896fb3e..b75c970b6806 100644
--- a/xen/arch/arm/include/asm/cache.h
+++ b/xen/arch/arm/include/asm/cache.h
@@ -6,9 +6,6 @@
 #define L1_CACHE_SHIFT  (CONFIG_ARM_L1_CACHE_SHIFT)
 #define L1_CACHE_BYTES  (1 << L1_CACHE_SHIFT)
 
-/* TODO: Phase out the use of this via cache.h */
-#define __read_mostly __section(".data.read_mostly")
-
 #endif
 /*
  * Local variables:
diff --git a/xen/include/xen/cache.h b/xen/include/xen/cache.h
index 90816ba05b1a..6ee174efa439 100644
--- a/xen/include/xen/cache.h
+++ b/xen/include/xen/cache.h
@@ -15,9 +15,4 @@
 #define __cacheline_aligned __attribute__((__aligned__(SMP_CACHE_BYTES)))
 #endif
 
-#if defined(CONFIG_ARM)
-/* TODO: Phase out the use of this via cache.h */
-#define __ro_after_init __section(".data.ro_after_init")
-#endif
-
 #endif /* __LINUX_CACHE_H */
-- 
2.39.2


Re: [PATCH 5/5] ARM/cache: Drop legacy __read_mostly/__ro_after_init definitions
Posted by Julien Grall 2 months, 1 week ago
Hi Andrew,

On 05/09/2024 23:08, Andrew Cooper wrote:
> These are no longer needed.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien@xen.org>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> CC: Bertrand Marquis <bertrand.marquis@arm.com>
> CC: Michal Orzel <michal.orzel@amd.com>
> ---
>   xen/arch/arm/include/asm/cache.h | 3 ---
>   xen/include/xen/cache.h          | 5 -----
>   2 files changed, 8 deletions(-)
> 
> diff --git a/xen/arch/arm/include/asm/cache.h b/xen/arch/arm/include/asm/cache.h
> index 029b2896fb3e..b75c970b6806 100644
> --- a/xen/arch/arm/include/asm/cache.h
> +++ b/xen/arch/arm/include/asm/cache.h
> @@ -6,9 +6,6 @@
>   #define L1_CACHE_SHIFT  (CONFIG_ARM_L1_CACHE_SHIFT)
>   #define L1_CACHE_BYTES  (1 << L1_CACHE_SHIFT)
>   
> -/* TODO: Phase out the use of this via cache.h */
> -#define __read_mostly __section(".data.read_mostly")
> -
>   #endif
>   /*
>    * Local variables:
> diff --git a/xen/include/xen/cache.h b/xen/include/xen/cache.h
> index 90816ba05b1a..6ee174efa439 100644
> --- a/xen/include/xen/cache.h
> +++ b/xen/include/xen/cache.h
> @@ -15,9 +15,4 @@
>   #define __cacheline_aligned __attribute__((__aligned__(SMP_CACHE_BYTES)))
>   #endif
>   
> -#if defined(CONFIG_ARM)
> -/* TODO: Phase out the use of this via cache.h */
> -#define __ro_after_init __section(".data.ro_after_init")
> -#endif
> -
>   #endif /* __LINUX_CACHE_H */

-- 
Julien Grall